From: "J. Bruce Fields" <bfields@fieldses.org>
To: Trond Myklebust <trond.myklebust@primarydata.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Linux NFS Mailing List <linux-nfs@vger.kernel.org>,
Devel FS Linux <linux-fsdevel@vger.kernel.org>,
Linux Kernel mailing list <linux-kernel@vger.kernel.org>,
Layton Jeff <jlayton@redhat.com>
Subject: Re: nfsd bug fixes for 3.15
Date: Thu, 24 Apr 2014 11:31:16 -0400 [thread overview]
Message-ID: <20140424153116.GA15459@fieldses.org> (raw)
In-Reply-To: <CAHQdGtRfybuqsxiS=Hd4Stkm1ex13f6SeEk5XbQcy35UZStHRA@mail.gmail.com>
On Thu, Apr 24, 2014 at 06:51:03AM -0400, Trond Myklebust wrote:
> Hi Bruce,
>
> On Thu, Apr 24, 2014 at 2:25 AM, J. Bruce Fields <bfields@fieldses.org> wrote:
> > Please pull the following bug fixes for 3.15 from:
> >
> > git://linux-nfs.org/~bfields/linux.git for-3.15
> >
> > Three small nfsd bugfixes (including one locks.c fix for a bug triggered
> > only from nfsd).
> >
> > Jeff's patches are for long-existing problems that became easier to
> > trigger since the addition of vfs delegation support.
> >
> > --b.
> >
> > ----------------------------------------------------------------
> > J. Bruce Fields (1):
> > Revert "nfsd4: fix nfs4err_resource in 4.1 case"
> >
>
> Wait. Why?
Have you changed your mind since our previous discussion, or just
forgotten it? (Or did I screw up and revert the wrong commit?) See
http://mid.gmane.org/<BAD6904F-A82A-4FBC-807F-16560B2A23E0@primarydata.com>
> NFS4ERR_RESOURCE breaks the Linux client.
This returns us to pre-3.15 behavior so shouldn't introduce any new
breakage.
Fundamentally the problem is that we're returning an error in cases that
shouldn't succeed, and rather than replacing one incorrect error by
another it seemed better to wait for a proper fix.
--b.
next prev parent reply other threads:[~2014-04-24 15:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-24 6:25 nfsd bug fixes for 3.15 J. Bruce Fields
2014-04-24 10:51 ` Trond Myklebust
2014-04-24 15:31 ` J. Bruce Fields [this message]
2014-04-24 16:34 ` J. Bruce Fields
2014-04-24 16:46 ` Trond Myklebust
2014-04-25 7:39 ` J. Bruce Fields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140424153116.GA15459@fieldses.org \
--to=bfields@fieldses.org \
--cc=jlayton@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=trond.myklebust@primarydata.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).