From mboxrd@z Thu Jan 1 00:00:00 1970 From: "J. Bruce Fields" Subject: Re: nfsd bug fixes for 3.15 Date: Thu, 24 Apr 2014 11:31:16 -0400 Message-ID: <20140424153116.GA15459@fieldses.org> References: <20140424062516.GA8891@fieldses.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Linus Torvalds , Linux NFS Mailing List , Devel FS Linux , Linux Kernel mailing list , Layton Jeff To: Trond Myklebust Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Thu, Apr 24, 2014 at 06:51:03AM -0400, Trond Myklebust wrote: > Hi Bruce, > > On Thu, Apr 24, 2014 at 2:25 AM, J. Bruce Fields wrote: > > Please pull the following bug fixes for 3.15 from: > > > > git://linux-nfs.org/~bfields/linux.git for-3.15 > > > > Three small nfsd bugfixes (including one locks.c fix for a bug triggered > > only from nfsd). > > > > Jeff's patches are for long-existing problems that became easier to > > trigger since the addition of vfs delegation support. > > > > --b. > > > > ---------------------------------------------------------------- > > J. Bruce Fields (1): > > Revert "nfsd4: fix nfs4err_resource in 4.1 case" > > > > Wait. Why? Have you changed your mind since our previous discussion, or just forgotten it? (Or did I screw up and revert the wrong commit?) See http://mid.gmane.org/ > NFS4ERR_RESOURCE breaks the Linux client. This returns us to pre-3.15 behavior so shouldn't introduce any new breakage. Fundamentally the problem is that we're returning an error in cases that shouldn't succeed, and rather than replacing one incorrect error by another it seemed better to wait for a proper fix. --b.