From: Al Viro <viro@ZenIV.linux.org.uk>
To: Sasha Levin <sasha.levin@oracle.com>
Cc: linux-fsdevel <linux-fsdevel@vger.kernel.org>,
Jan Kara <jack@suse.cz>, Dave Jones <davej@redhat.com>,
LKML <linux-kernel@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Glauber Costa <glommer@parallels.com>,
Christoph Lameter <cl@linux.com>
Subject: Re: fs: dcookie: freeing active timer
Date: Fri, 25 Apr 2014 00:49:41 +0100 [thread overview]
Message-ID: <20140424234941.GA18016@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20140424215558.GZ18016@ZenIV.linux.org.uk>
On Thu, Apr 24, 2014 at 10:55:58PM +0100, Al Viro wrote:
> On Thu, Apr 24, 2014 at 01:34:14PM -0400, Sasha Levin wrote:
>
> > > Why does that code bother with destroying/creating that sucker dynamically?
> > > Is there any point at all?
> >
> > I'm not sure about the dynamic allocation part, but I fear that if we just
> > switch to using static allocations it'll hide the underlying issue that
> > triggered this bug instead of fixing it.
>
> FWIW, slub.c variant of kmem_cache_destroy() is buggered - struct kobject
> embedded into struct kmem_cache, its ktype is slab_ktype, which has
> NULL ->release()...
BTW, if your config has CONFIG_DEBUG_KOBJECT_RELEASE, that's exactly where
that warning comes from. Got broken by commit b7454a,
Author: Glauber Costa <glommer@parallels.com>
Date: Fri Oct 19 18:20:25 2012 +0400
mm/sl[au]b: Move slabinfo processing to slab_common.c
We *do* need ->release(). Greg and guilty parties Cc'd...
next prev parent reply other threads:[~2014-04-24 23:49 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-24 16:56 fs: dcookie: freeing active timer Sasha Levin
2014-04-24 17:27 ` Al Viro
2014-04-24 17:34 ` Sasha Levin
2014-04-24 21:55 ` Al Viro
2014-04-24 23:49 ` Al Viro [this message]
2014-04-25 3:31 ` Sasha Levin
2014-04-30 21:48 ` Sasha Levin
2014-04-30 23:19 ` Christoph Lameter
2014-05-01 20:10 ` Andrew Morton
2014-05-01 20:23 ` Christoph Lameter
2014-05-05 20:44 ` Sasha Levin
2014-05-05 20:51 ` Andrew Morton
2014-05-06 12:31 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140424234941.GA18016@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=cl@linux.com \
--cc=davej@redhat.com \
--cc=glommer@parallels.com \
--cc=gregkh@linuxfoundation.org \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sasha.levin@oracle.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).