From: "J. Bruce Fields" <bfields@fieldses.org>
To: Jeff Layton <jlayton@redhat.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [GIT PULL] please pull file locking changes for v3.15 (pile #2)
Date: Fri, 25 Apr 2014 06:01:17 -0400 [thread overview]
Message-ID: <20140425100117.GC22295@fieldses.org> (raw)
In-Reply-To: <20140425095739.GB22295@fieldses.org>
On Fri, Apr 25, 2014 at 05:57:39AM -0400, J. Bruce Fields wrote:
> On Thu, Apr 24, 2014 at 07:45:57AM -0400, Jeff Layton wrote:
> >
> > The following changes since commit 55101e2d6ce1c780f6ee8fee5f37306971aac6cd:
> >
> > Merge git://git.kernel.org/pub/scm/virt/kvm/kvm (2014-04-14 16:21:28 -0700)
> >
> > are available in the git repository at:
> >
> >
> > git://git.samba.org/jlayton/linux.git tags/locks-v3.15-2
> >
> > for you to fetch changes up to cff2fce58b2b0f59089e7edcdc38803d65057b9f:
> >
> > locks: rename FL_FILE_PVT and IS_FILE_PVT to use "*_OFDLCK" instead (2014-04-23 16:17:03 -0400)
> >
> > ----------------------------------------------------------------
> > File locking related bugfixes for v3.15 (pile #2)
> >
> > - fix for a long-standing bug in __break_lease that can cause soft lockups
> > - renaming of file-private locks to "open file description" locks, and the
> > command macros to more visually distinct names.
> >
> > The fix for __break_lease is also in the pile of patches for which Bruce
> > sent a pull request, but I assume that your merge procedure will handle
> > that correctly.
> >
> > For the other patches, I don't like the fact that we need to rename this
> > stuff at this late stage, but it should be settled now (hopefully).
> >
> > ----------------------------------------------------------------
> > Jeff Layton (3):
> > locks: allow __break_lease to sleep even when break_time is 0
> > locks: rename file-private locks to "open file description locks"
>
> Nit: they're "descriptors", not "descriptions".
>
> But since that only affects comments and changelogs (not even the macros
> names, which are using OFD), that's a very nitty nit....
(So, ACK to the merge. Just make sure the typo doesn't creep into man
pages.)
--b.
next prev parent reply other threads:[~2014-04-25 10:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-24 11:45 [GIT PULL] please pull file locking changes for v3.15 (pile #2) Jeff Layton
2014-04-25 9:57 ` J. Bruce Fields
2014-04-25 10:01 ` J. Bruce Fields [this message]
2014-04-25 10:35 ` Christoph Hellwig
2014-04-25 10:39 ` Jeff Layton
2014-04-26 16:46 ` J. Bruce Fields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140425100117.GC22295@fieldses.org \
--to=bfields@fieldses.org \
--cc=jlayton@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).