From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH -V1 00/22] New ACL format for better NFSv4 acl interoperability Date: Mon, 28 Apr 2014 02:03:56 -0700 Message-ID: <20140428090356.GA20147@infradead.org> References: <1398615293-22931-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com> <20140428043909.GA26778@infradead.org> <87wqeaatj3.fsf@linux.vnet.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: agruen-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, bfields-uC3wQj2KruNg9hUCZPvPmw@public.gmane.org, akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org, viro-RmSDqhL/yNMiFSDQTTA3OLVCufUGDwFn@public.gmane.org, dhowells-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: "Aneesh Kumar K.V" Return-path: Content-Disposition: inline In-Reply-To: <87wqeaatj3.fsf-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org> Sender: linux-nfs-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-fsdevel.vger.kernel.org On Mon, Apr 28, 2014 at 11:24:08AM +0530, Aneesh Kumar K.V wrote: > We already do that with richacl. Richacl already have most of the > details implemented in common code. Comparing to recent posix acl > changes we could still simplify chmod and xattr bits. I will do that > in the next update. There's still tons of duplication. There should be no code in the filesystem except for a few callouts for the inode init and chmod path, and the attr set/get should also be mostly in a library. If you need to add more than 20 lines to the filesystem you did something wrong. > > > - common data structure with Posix ACLs > > > > Can you explain this ?. Why do we want to do that ? One acl structure implementing the Posix and NFSv4 acls and instead of a big pile of duplicate infrastructure. -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html