From: Christoph Hellwig <hch@infradead.org>
To: Matthew Wilcox <willy@linux.intel.com>
Cc: Marco Munderloh <munderl@tnt.uni-hannover.de>,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH V2] catch acl==NULL in __jfs_set_acl (fixed null pointer dereference)
Date: Tue, 29 Apr 2014 11:28:07 -0700 [thread overview]
Message-ID: <20140429182807.GA27375@infradead.org> (raw)
In-Reply-To: <20140429182602.GD5929@linux.intel.com>
On Tue, Apr 29, 2014 at 02:26:02PM -0400, Matthew Wilcox wrote:
> On Tue, Apr 29, 2014 at 07:59:51PM +0200, Marco Munderloh wrote:
> > changes V2: I forgot to set rc = 0, leaving it uninitialized if acl was NULL.
>
> You don't need to initialise rc here. But why not, more simply:
I'm pretty sure there's a patch queued up somewhere to make
posix_acl_equiv_mode handle the NULL ACL. I think this was first
reportd on gfs2.
next prev parent reply other threads:[~2014-04-29 18:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-29 17:59 [PATCH V2] catch acl==NULL in __jfs_set_acl (fixed null pointer dereference) Marco Munderloh
2014-04-29 18:26 ` Matthew Wilcox
2014-04-29 18:28 ` Christoph Hellwig [this message]
2014-04-29 18:33 ` Marco Munderloh
2014-04-29 18:30 ` Marco Munderloh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140429182807.GA27375@infradead.org \
--to=hch@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=munderl@tnt.uni-hannover.de \
--cc=willy@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).