From mboxrd@z Thu Jan  1 00:00:00 1970
From: Christoph Hellwig <hch@infradead.org>
Subject: Re: [PATCH V2] catch acl==NULL in __jfs_set_acl (fixed null pointer
 dereference)
Date: Tue, 29 Apr 2014 11:28:07 -0700
Message-ID: <20140429182807.GA27375@infradead.org>
References: <535FE897.9040607@tnt.uni-hannover.de>
 <20140429182602.GD5929@linux.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Marco Munderloh <munderl@tnt.uni-hannover.de>,
	linux-fsdevel@vger.kernel.org
To: Matthew Wilcox <willy@linux.intel.com>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from bombadil.infradead.org ([198.137.202.9]:36942 "EHLO
	bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S932491AbaD2S2Q (ORCPT
	<rfc822;linux-fsdevel@vger.kernel.org>);
	Tue, 29 Apr 2014 14:28:16 -0400
Content-Disposition: inline
In-Reply-To: <20140429182602.GD5929@linux.intel.com>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On Tue, Apr 29, 2014 at 02:26:02PM -0400, Matthew Wilcox wrote:
> On Tue, Apr 29, 2014 at 07:59:51PM +0200, Marco Munderloh wrote:
> > changes V2: I forgot to set rc = 0, leaving it uninitialized if acl was NULL.
> 
> You don't need to initialise rc here.  But why not, more simply:

I'm pretty sure there's a patch queued up somewhere to make
posix_acl_equiv_mode handle the NULL ACL.  I think this was first
reportd on gfs2.