From mboxrd@z Thu Jan 1 00:00:00 1970 From: Al Viro Subject: Re: dcache shrink list corruption? Date: Fri, 2 May 2014 06:51:27 +0100 Message-ID: <20140502055127.GH18016@ZenIV.linux.org.uk> References: <20140429181610.GJ18016@ZenIV.linux.org.uk> <20140429191015.GK18016@ZenIV.linux.org.uk> <20140429211851.GA32204@dastard> <20140429214842.GL18016@ZenIV.linux.org.uk> <20140429232013.GM18016@ZenIV.linux.org.uk> <20140430023142.GN18016@ZenIV.linux.org.uk> <20140430091515.GB3113@tucsk.piliscsaba.szeredi.hu> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Linus Torvalds , Dave Chinner , Linux Kernel Mailing List , linux-fsdevel To: Miklos Szeredi Return-path: Content-Disposition: inline In-Reply-To: <20140430091515.GB3113@tucsk.piliscsaba.szeredi.hu> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Wed, Apr 30, 2014 at 11:15:15AM +0200, Miklos Szeredi wrote: > On Tue, Apr 29, 2014 at 07:56:13PM -0700, Linus Torvalds wrote: > > On Tue, Apr 29, 2014 at 7:31 PM, Al Viro wrote: > > > > > > OK, aggregate diff follows, more readable splitup (3 commits) attached. > > > It seems to survive beating here; testing, review and comments are > > > welcome. > > > > Miklos, did you have some particular load that triggered this, or was > > it just some reports? It would be really good to get this patch some > > stress-testing. > > > > I like how the patch removes more lines than it adds, but apart from > > that it's hard to read the patch (even the split-out ones) and say > > anything more about it. I think this needs a *lot* of testing. > > IBM is triggering this with the host01 test from the LTP suite. I haven't yet > tried to reproduce it. Could you repost their report? So far I hadn't managed to get actual list corruption on mainline kernel - it definitely is possible, but on all testcases so far the race window is too narrow. So if they have a reproducer that doesn't take an insane amount of time, I'd really like to see it...