From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthew Wilcox Subject: Re: [PATCH] posix_acl: handle NULL ACL in posix_acl_equiv_mode Date: Mon, 5 May 2014 09:57:19 -0400 Message-ID: <20140505135719.GE5929@linux.intel.com> References: <1399201412-17938-1-git-send-email-hch@lst.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Al Viro , linux-fsdevel@vger.kernel.org, Chuck Lever , stable@vger.kernel.org To: Christoph Hellwig Return-path: Received: from mga03.intel.com ([143.182.124.21]:52821 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932395AbaEEN5h (ORCPT ); Mon, 5 May 2014 09:57:37 -0400 Content-Disposition: inline In-Reply-To: <1399201412-17938-1-git-send-email-hch@lst.de> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Sun, May 04, 2014 at 01:03:32PM +0200, Christoph Hellwig wrote: > Various filesystems don't bother checking for a NULL ACL in > posix_acl_equiv_mode, and thus can dereference a NULL pointer when it > gets passed one. This usually happens from the NFS server, as the ACL tools > never pass a NULL ACL, but instead of one representing the mode bits. > > Instead of adding boilerplat to all filesystems put this check into one place, > which will allow us to remove the check from other filesystems as well later > on. > > Signed-off-by: Christoph Hellwig > Reported-by: Ben Greear > Reported-by: Marco Munderloh , > Cc: Chuck Lever > Cc: stable@vger.kernel.org Reviewed-by: Matthew Wilcox