From: Christoph Hellwig <hch@infradead.org>
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: Al Viro <viro@ZenIV.linux.org.uk>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
Chris Mason <clm@fb.com>, Jan Kara <jack@suse.cz>,
Theodore Ts'o <tytso@mit.edu>,
Jaegeuk Kim <jaegeuk.kim@samsung.com>,
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>,
Mikulas Patocka <mpatocka@redhat.com>,
David Woodhouse <dwmw2@infradead.org>,
Dave Kleikamp <dave.kleikamp@oracle.com>,
Joern Engel <joern@logfs.org>,
Ryusuke Konishi <konishi.ryusuke@lab.ntt.co.jp>,
Bob Copeland <me@bobcopeland.com>,
Christoph Hellwig <hch@infradead.org>,
Artem Bityutskiy <dedekind1@gmail.com>,
Dave Chinner <david@fromorbit.com>
Subject: Re: [PATCH] vfs: add noreplace_rename2()
Date: Tue, 13 May 2014 07:05:57 -0700 [thread overview]
Message-ID: <20140513140557.GA30660@infradead.org> (raw)
In-Reply-To: <20140513135622.GB17233@tucsk.piliscsaba.szeredi.hu>
On Tue, May 13, 2014 at 03:56:22PM +0200, Miklos Szeredi wrote:
> From: Miklos Szeredi <mszeredi@suse.cz>
>
> RENAME_NOREPLACE is trivial to implement for most filesystems. This adds a
> helper that can be assigned to ->rename2() and calls ->rename().
>
> Only suitable for local filesystems, i.e. those that cannot have files
> "spontaneously" appear (like NFS and friends).
I don't like this approach at all. Please bite the bullet and rename
->rename2 to ->rename and all the proper rejecting of non-supported
flags intstead of further locking down the duplication.
next prev parent reply other threads:[~2014-05-13 14:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-13 13:56 [PATCH] vfs: add noreplace_rename2() Miklos Szeredi
2014-05-13 14:05 ` Christoph Hellwig [this message]
2014-05-13 14:43 ` Miklos Szeredi
2014-05-13 15:29 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140513140557.GA30660@infradead.org \
--to=hch@infradead.org \
--cc=clm@fb.com \
--cc=dave.kleikamp@oracle.com \
--cc=david@fromorbit.com \
--cc=dedekind1@gmail.com \
--cc=dwmw2@infradead.org \
--cc=hirofumi@mail.parknet.co.jp \
--cc=jack@suse.cz \
--cc=jaegeuk.kim@samsung.com \
--cc=joern@logfs.org \
--cc=konishi.ryusuke@lab.ntt.co.jp \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=me@bobcopeland.com \
--cc=miklos@szeredi.hu \
--cc=mpatocka@redhat.com \
--cc=tytso@mit.edu \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).