From: Christoph Hellwig <hch@infradead.org>
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: Al Viro <viro@ZenIV.linux.org.uk>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
Stephen Rothwell <sfr@au1.ibm.com>
Subject: Re: [PATCH] vfs: add noreplace_rename2()
Date: Tue, 13 May 2014 08:29:11 -0700 [thread overview]
Message-ID: <20140513152911.GB15679@infradead.org> (raw)
In-Reply-To: <20140513144354.GG17233@tucsk.piliscsaba.szeredi.hu>
On Tue, May 13, 2014 at 04:43:54PM +0200, Miklos Szeredi wrote:
> There was pushback from Stephen Rothwell as well as Al, which is why it ended up
> being a separate op.
I can see some reason to not want it for an inintial merged, but having
two parallel methods in the long run is a bad design.
> I was always hoping to merge the two, but until there's clear indication that
> it's going to get accepted, there's no point in me preparing and maintaining
> such a patch.
How about we slowly work towards doing the right thing?
1) make vfs_rename call ->rename2 if it exists instead of ->rename
2) switch all filesystems that you're adding NOREPLACE support for to
use ->rename2
3) see how many ->rename instances we'll have left after a few
iterations of 2.
A default method implementation that just calls a slightly more
complicated version of the method is just useless clutter.
prev parent reply other threads:[~2014-05-13 15:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-13 13:56 [PATCH] vfs: add noreplace_rename2() Miklos Szeredi
2014-05-13 14:05 ` Christoph Hellwig
2014-05-13 14:43 ` Miklos Szeredi
2014-05-13 15:29 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140513152911.GB15679@infradead.org \
--to=hch@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=sfr@au1.ibm.com \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).