From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Chinner Subject: Re: [PATCH 2/2] fs: print a message when freezing/unfreezing filesystems Date: Thu, 15 May 2014 07:54:57 +1000 Message-ID: <20140514215457.GC5421@dastard> References: <1400005862-3751-1-git-send-email-mguzik@redhat.com> <1400005862-3751-2-git-send-email-mguzik@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, Josef Bacik , Jan Kara , Al Viro , Eric Sandeen To: Mateusz Guzik Return-path: Content-Disposition: inline In-Reply-To: <1400005862-3751-2-git-send-email-mguzik@redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Tue, May 13, 2014 at 08:31:02PM +0200, Mateusz Guzik wrote: > This helps hang troubleshooting efforts when only dmesg is available. I really don't think that spamming dmesg every time a filesystem is frozen or thawed is a good idea. This happens a *lot* when systems are using snapshots, and for the most part nobody cares about freeze/thaw cycles because they almost always work just fine. I'd think that /proc/self/mounts would be a much better place to indicate that the fs is frozen. After all, that's where we tell people whether the filesystem is ro or rw, and frozen is just a temporary, non-invasive ro state... Cheers, Dave. -- Dave Chinner david@fromorbit.com