* [PATCH] ext4: remove unused local variable "stored" from ext4_readdir(...)
@ 2014-05-21 15:32 Giedrius Rekasius
2014-05-21 17:44 ` Dan Carpenter
2014-05-26 16:34 ` Theodore Ts'o
0 siblings, 2 replies; 3+ messages in thread
From: Giedrius Rekasius @ 2014-05-21 15:32 UTC (permalink / raw)
To: Theodore Ts'o
Cc: Andreas Dilger, linux-ext4, linux-kernel, kernel-janitors,
linux-fsdevel
From: Giedrius Rekasius <giedrius.rekasius@gmail.com>
Remove local variable "stored" from ext4_readdir(...). This variable
gets initialized but is never used inside the function.
Signed-off-by: Giedrius Rekasius <giedrius.rekasius@gmail.com>
---
fs/ext4/dir.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/fs/ext4/dir.c b/fs/ext4/dir.c
index d638c57..ef1bed6 100644
--- a/fs/ext4/dir.c
+++ b/fs/ext4/dir.c
@@ -105,7 +105,7 @@ int __ext4_check_dir_entry(const char *function, unsigned int line,
static int ext4_readdir(struct file *file, struct dir_context *ctx)
{
unsigned int offset;
- int i, stored;
+ int i;
struct ext4_dir_entry_2 *de;
int err;
struct inode *inode = file_inode(file);
@@ -133,7 +133,6 @@ static int ext4_readdir(struct file *file, struct dir_context *ctx)
return ret;
}
- stored = 0;
offset = ctx->pos & (sb->s_blocksize - 1);
while (ctx->pos < inode->i_size) {
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] ext4: remove unused local variable "stored" from ext4_readdir(...)
2014-05-21 15:32 [PATCH] ext4: remove unused local variable "stored" from ext4_readdir(...) Giedrius Rekasius
@ 2014-05-21 17:44 ` Dan Carpenter
2014-05-26 16:34 ` Theodore Ts'o
1 sibling, 0 replies; 3+ messages in thread
From: Dan Carpenter @ 2014-05-21 17:44 UTC (permalink / raw)
To: Giedrius Rekasius
Cc: Theodore Ts'o, Andreas Dilger, linux-ext4, linux-kernel,
kernel-janitors, linux-fsdevel
On Wed, May 21, 2014 at 04:32:26PM +0100, Giedrius Rekasius wrote:
> From: Giedrius Rekasius <giedrius.rekasius@gmail.com>
>
> Remove local variable "stored" from ext4_readdir(...). This variable
> gets initialized but is never used inside the function.
>
> Signed-off-by: Giedrius Rekasius <giedrius.rekasius@gmail.com>
Looks good.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ext4: remove unused local variable "stored" from ext4_readdir(...)
2014-05-21 15:32 [PATCH] ext4: remove unused local variable "stored" from ext4_readdir(...) Giedrius Rekasius
2014-05-21 17:44 ` Dan Carpenter
@ 2014-05-26 16:34 ` Theodore Ts'o
1 sibling, 0 replies; 3+ messages in thread
From: Theodore Ts'o @ 2014-05-26 16:34 UTC (permalink / raw)
To: Giedrius Rekasius
Cc: Andreas Dilger, linux-ext4, linux-kernel, kernel-janitors,
linux-fsdevel
On Wed, May 21, 2014 at 04:32:26PM +0100, Giedrius Rekasius wrote:
> From: Giedrius Rekasius <giedrius.rekasius@gmail.com>
>
> Remove local variable "stored" from ext4_readdir(...). This variable
> gets initialized but is never used inside the function.
>
> Signed-off-by: Giedrius Rekasius <giedrius.rekasius@gmail.com>
Applied, thanks.
- Ted
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-05-26 16:34 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-05-21 15:32 [PATCH] ext4: remove unused local variable "stored" from ext4_readdir(...) Giedrius Rekasius
2014-05-21 17:44 ` Dan Carpenter
2014-05-26 16:34 ` Theodore Ts'o
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).