From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ingo Molnar Subject: Re: [PATCH] SCHED: remove proliferation of wait_on_bit action functions. Date: Thu, 22 May 2014 11:05:02 +0200 Message-ID: <20140522090502.GB30094@gmail.com> References: <20140501123738.3e64b2d2@notabene.brown> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Peter Zijlstra , Oleg Nesterov , David Howells , Steven Whitehouse , dm-devel@redhat.com, Chris Mason , Josef Bacik , Steve French , Theodore Ts'o , Trond Myklebust , Ingo Molnar , Roland McGrath , Andrew Morton , linux-nfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org To: NeilBrown Return-path: Content-Disposition: inline In-Reply-To: <20140501123738.3e64b2d2@notabene.brown> Sender: owner-linux-mm@kvack.org List-Id: linux-fsdevel.vger.kernel.org * NeilBrown wrote: > [[ get_maintainer.pl suggested 61 email address for this patch. > I've trimmed that list somewhat. Hope I didn't miss anyone > important... > I'm hoping it will go in through the scheduler tree, but would > particularly like an Acked-by for the fscache parts. Other acks > welcome. > ]] > > The current "wait_on_bit" interface requires an 'action' function > to be provided which does the actual waiting. > There are over 20 such functions, many of them identical. > Most cases can be satisfied by one of just two functions, one > which uses io_schedule() and one which just uses schedule(). > > So: > Rename wait_on_bit and wait_on_bit_lock to > wait_on_bit_action and wait_on_bit_lock_action > to make it explicit that they need an action function. > > Introduce new wait_on_bit{,_lock} and wait_on_bit{,_lock}_io > which are *not* given an action function but implicitly use > a standard one. > The decision to error-out if a signal is pending is now made > based on the 'mode' argument rather than being encoded in the action > function. this patch fails to build on x86-32 allyesconfigs. Could we keep the old names for a while, and remove them in the next cycle or so? Thanks, Ingo -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org