From: Maurizio Lombardi <mlombard@redhat.com>
To: Ming Lei <tom.leiming@gmail.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>,
Andrew Morton <akpm@linux-foundation.org>,
Linux FS Devel <linux-fsdevel@vger.kernel.org>,
"James E.J. Bottomley" <JBottomley@parallels.com>,
Christoph Hellwig <hch@lst.de>,
linux-scsi@vger.kernel.org, Kent Overstreet <kmo@daterainc.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
m.lombardi85@gmail.com
Subject: Re: [PATCH V3] bio: modify __bio_add_page() to accept pages that don't start a new segment
Date: Tue, 27 May 2014 13:58:59 +0200 [thread overview]
Message-ID: <20140527115859.GA30458@dhcp-27-189.brq.redhat.com> (raw)
In-Reply-To: <CACVXFVNSZ7+MxW8-SiLXUFW6pGJ7b-OQzf8-KLzcXyE7BvhbbA@mail.gmail.com>
On Tue, May 27, 2014 at 06:15:45PM +0800, Ming Lei wrote:
>
> If the page can be merged to last segment, it should have been
> covered by code in branch of 'if (bio->bi_vcnt > 0) ...', shouldn't it?
>
> Or maybe it is better to make that code cover your case since
> looks your case is similar with that one according to your commit
> log.
>
I realized that maybe you mean this branch:
if (bio->bi_vcnt > 1 && (BIOVEC_PHYS_MERGEABLE(bvec-1, bvec)))
right?
In this case the branch is not even reached in the original code because
the function returned an error way before executing it (line 760)
There was already a patchset trying to modify the code in a different way than mine:
https://groups.google.com/forum/#!msg/linux.kernel/3IanUpBVhFQ/3Xbg3yLRFp4J
but it has been ignored and in my opinion it takes a more
complicated approach.
Regards,
Maurizio Lombardi
next prev parent reply other threads:[~2014-05-27 11:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-01 13:56 [PATCH V3] bio: modify __bio_add_page() to accept pages that don't start a new segment Maurizio Lombardi
2014-05-27 10:15 ` Ming Lei
2014-05-27 11:14 ` Maurizio Lombardi
2014-05-27 11:58 ` Maurizio Lombardi [this message]
2014-05-27 14:04 ` Ming Lei
2014-05-27 14:27 ` Maurizio Lombardi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140527115859.GA30458@dhcp-27-189.brq.redhat.com \
--to=mlombard@redhat.com \
--cc=JBottomley@parallels.com \
--cc=akpm@linux-foundation.org \
--cc=hch@lst.de \
--cc=kmo@daterainc.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=m.lombardi85@gmail.com \
--cc=tom.leiming@gmail.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).