From: Djalal Harouni <tixxdz@opendz.org>
To: Andy Lutomirski <luto@amacapital.net>
Cc: Kees Cook <keescook@chromium.org>,
Andrew Morton <akpm@linux-foundation.org>,
Alexey Dobriyan <adobriyan@gmail.com>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Al Viro <viro@zeniv.linux.org.uk>,
Linus Torvalds <torvalds@linux-foundation.org>,
Ingo Molnar <mingo@kernel.org>, Oleg Nesterov <oleg@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
LKML <linux-kernel@vger.kernel.org>,
Linux FS Devel <linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH 1/9] procfs: use flags to deny or allow access to /proc/<pid>/$entry
Date: Tue, 27 May 2014 14:42:18 +0100 [thread overview]
Message-ID: <20140527134218.GB3148@dztty> (raw)
In-Reply-To: <CALCETrU1xjXvwtuYyqGhDgch7cZgP_LWLNDC8b8oeEtwJ0UNmg@mail.gmail.com>
On Mon, May 26, 2014 at 12:17:48PM -0700, Andy Lutomirski wrote:
> On Mon, May 26, 2014 at 12:13 PM, Djalal Harouni <tixxdz@opendz.org> wrote:
> > On Mon, May 26, 2014 at 11:06:40AM -0700, Andy Lutomirski wrote:
> >> On Mon, May 26, 2014 at 10:21 AM, Djalal Harouni <tixxdz@opendz.org> wrote:
> >> > I would like to keep it enum, enum is type-safe and I want to follow the
> >> > semantics of /proc/pid/stat and others:
> >>
> >> It's not type-safe the way you're doing it, though.
> > Can you please shed some light Andy, thank you in advance!
>
> You're casting these things back and forth. If you were storing enum
> values in an enum-typed variable, great, but you're not.
Ok I see your point! Yes, but AFAIK in this case it's perfectly safe!
We don't use large values, the one used here can be represented as an
int, and later we cast them to unsigned long to make sure that we are
using the correct value and the correct size of a pointer.
GCC is able to warn in this case of any appropriate cast:
-Wpointer-to-int-cast ...
And from Documentation/CodingStyle:
"Enums are preferred when defining several related constants."
Perhaps I'm missing something!
> --Andy
--
Djalal Harouni
http://opendz.org
next prev parent reply other threads:[~2014-05-27 13:42 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-26 13:27 [PATCH 0/9] procfs: smooth steps to secure some /proc/<pid>/* Djalal Harouni
2014-05-26 13:27 ` [PATCH 1/9] procfs: use flags to deny or allow access to /proc/<pid>/$entry Djalal Harouni
2014-05-26 16:57 ` Andy Lutomirski
2014-05-26 17:21 ` Djalal Harouni
2014-05-26 18:06 ` Andy Lutomirski
2014-05-26 19:13 ` Djalal Harouni
2014-05-26 19:17 ` Andy Lutomirski
2014-05-27 13:42 ` Djalal Harouni [this message]
2014-05-27 18:38 ` Kees Cook
2014-05-28 11:42 ` Djalal Harouni
2014-05-28 16:59 ` Kees Cook
2014-05-28 19:11 ` Djalal Harouni
2014-05-26 13:27 ` [PATCH 2/9] procfs: add pid_entry_access() for proper checks on /proc/<pid>/* Djalal Harouni
2014-05-26 16:57 ` Andy Lutomirski
2014-05-26 13:27 ` [PATCH 3/9] procfs: add proc_read_from_buffer() and pid_entry_read() helpers Djalal Harouni
2014-05-26 17:01 ` Andy Lutomirski
2014-05-26 17:41 ` Djalal Harouni
2014-05-26 17:59 ` Andy Lutomirski
2014-05-26 18:21 ` Djalal Harouni
2014-05-26 18:44 ` Djalal Harouni
2014-06-03 10:13 ` Alexey Dobriyan
2014-05-26 13:27 ` [PATCH 4/9] procfs: improve /proc/<pid>/wchan protection Djalal Harouni
2014-05-26 13:27 ` [PATCH 5/9] procfs: improve /proc/<pid>/syscall protection Djalal Harouni
2014-05-26 13:27 ` [PATCH 6/9] procfs: add pid_seq_private struct to handle /proc/<pid>/{stat|stack} Djalal Harouni
2014-05-26 17:02 ` Andy Lutomirski
2014-05-27 11:18 ` Djalal Harouni
2014-05-26 13:27 ` [PATCH 7/9] procfs: add pid_entry_show() helper " Djalal Harouni
2014-05-26 13:27 ` [PATCH 8/9] procfs: improve /proc/<pid>/stat protection Djalal Harouni
2014-05-26 13:27 ` [PATCH 9/9] procfs: improve /proc/<pid>/stack protection Djalal Harouni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140527134218.GB3148@dztty \
--to=tixxdz@opendz.org \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=ebiederm@xmission.com \
--cc=keescook@chromium.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=mingo@kernel.org \
--cc=oleg@redhat.com \
--cc=peterz@infradead.org \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox