From mboxrd@z Thu Jan 1 00:00:00 1970 From: Al Viro Subject: Re: [PATCH] vfs: fix vmplice_to_user() Date: Tue, 27 May 2014 18:51:57 +0100 Message-ID: <20140527175157.GU18016@ZenIV.linux.org.uk> References: <20140527144116.GK17233@tucsk.piliscsaba.szeredi.hu> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Linus Torvalds , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org To: Miklos Szeredi Return-path: Content-Disposition: inline In-Reply-To: <20140527144116.GK17233@tucsk.piliscsaba.szeredi.hu> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Tue, May 27, 2014 at 04:41:16PM +0200, Miklos Szeredi wrote: > From: Miklos Szeredi > > Commit 6130f5315ee8 "switch vmsplice_to_user() to copy_page_to_iter()" in > v3.15-rc1 broke vmsplice(2). > > This patch fixes two bugs: > > - count is not initialized to a proper value, which resulted in no data > being copied > > - if rw_copy_check_uvector() returns negative then the iov might be leaked. > > Tested OK. Applied, will push tonight.