From mboxrd@z Thu Jan 1 00:00:00 1970 From: Al Viro Subject: Re: fs/dcache.c - BUG: soft lockup - CPU#5 stuck for 22s! [systemd-udevd:1667] Date: Thu, 29 May 2014 14:30:36 +0100 Message-ID: <20140529133036.GJ18016@ZenIV.linux.org.uk> References: <20140528073751.GB1757@lahna.fi.intel.com> <20140528115701.GY18016@ZenIV.linux.org.uk> <20140528131136.GA1643@lahna.fi.intel.com> <20140528141937.GZ18016@ZenIV.linux.org.uk> <20140528183954.GA18016@ZenIV.linux.org.uk> <20140529031149.GE18016@ZenIV.linux.org.uk> <20140529035233.GF18016@ZenIV.linux.org.uk> <20140529053444.GI18016@ZenIV.linux.org.uk> <20140529105107.GB1938@lahna.fi.intel.com> <20140529110439.GA2006@lahna.fi.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Linus Torvalds , Linux Kernel Mailing List , Miklos Szeredi , linux-fsdevel To: Mika Westerberg Return-path: Content-Disposition: inline In-Reply-To: <20140529110439.GA2006@lahna.fi.intel.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Thu, May 29, 2014 at 02:04:39PM +0300, Mika Westerberg wrote: > With your both patches applied the problem is gone :-) > > I did 20 plug/unplugs, rebooted the machine and another 20 plug/unplugs > and didn't see the livelock at once. Great... OK, saner splitup of that sucker (equivalent to combination of these two patches) is in vfs.git#for-linus. Review and testing would be very welcome. PS: The diff between that and aforementioned "both patches applied" is noise - dentry and parent declarations had been moved into the loop body there, while in #for-linus they are left alone. So Mika's testing results should apply to that one as well.