From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tejun Heo Subject: Re: 3.15 regression: wrong cgroup magic Date: Mon, 2 Jun 2014 21:22:11 -0400 Message-ID: <20140603012211.GE19855@htj.dyndns.org> References: <538D2261.70406@huawei.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Andy Lutomirski , "linux-kernel@vger.kernel.org" , Linux FS Devel , Linus Torvalds , Greg Kroah-Hartman , Jianyu Zhan To: Li Zefan Return-path: Content-Disposition: inline In-Reply-To: <538D2261.70406@huawei.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Tue, Jun 03, 2014 at 09:18:25AM +0800, Li Zefan wrote: > > commit 2bd59d48ebfb3df41ee56938946ca0dd30887312 > > Author: Tejun Heo > > Date: Tue Feb 11 11:52:49 2014 -0500 > > > > cgroup: convert to kernfs > > > > In particular, this piece: > > > > - sb->s_magic = CGROUP_SUPER_MAGIC; > > > > The result is that cgroup shows up with the wrong magic number, so my > > code goes "oh crap, cgroupfs isn't mounted" and fails. > > > > I can change my code to hack around this, but I can imagine other > > things getting tripped up. Is there still time to fix this? > > > > This should be fixed by "kernfs: move the last knowledge of sysfs out from kernfs". > > It's in driver-core-next. > > https://git.kernel.org/cgit/linux/kernel/git/gregkh/driver-core.git/commit/?h=driver-core-next&id=26fc9cd200ec839e0b3095e05ae018f27314e7aa Right, I was writing about the same patch with a nagging sense of deja-vu. I should have noticed that this must go through driver-core-linus not -next. Sorry about that. Linus, can you please cherry-pick the commit? Thanks. -- tejun