From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Subject: Re: [PATCH] list: Fix order of arguments for hlist_add_after(_rcu) Date: Fri, 6 Jun 2014 08:50:12 -0700 Message-ID: <20140606155012.GA15110@kroah.com> References: <1402047743-3391-1-git-send-email-kenhelias@firemail.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: devel@driverdev.osuosl.org, b.a.t.m.a.n@lists.open-mesh.org, netdev@vger.kernel.org, bridge@lists.linux-foundation.org, lkml , dri-devel@lists.freedesktop.org, linux-fsdevel@vger.kernel.org, paulmck@linux.vnet.ibm.com To: Ken Helias Return-path: Content-Disposition: inline In-Reply-To: <1402047743-3391-1-git-send-email-kenhelias@firemail.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" List-Id: linux-fsdevel.vger.kernel.org On Fri, Jun 06, 2014 at 11:42:23AM +0200, Ken Helias wrote: > All other add functions for lists have the new item as first argument and the > position where it is added as second argument. This was changed for no good > reason in this function and makes using it unnecessary confusing. > > Also the naming of the arguments in hlist_add_after was confusing. It was > changed to use the same names as hlist_add_after_rcu. > > Signed-off-by: Ken Helias > Cc: David Airlie > Cc: Jeff Kirsher > Cc: Jesse Brandeburg > Cc: Bruce Allan > Cc: Carolyn Wyborny > Cc: Don Skidmore > Cc: Greg Rose > Cc: Alex Duyck > Cc: John Ronciak > Cc: Mitch Williams > Cc: Linux NICS > Cc: Alexander Viro > Cc: Dipankar Sarma > Cc: "Paul E. McKenney" > Cc: Marek Lindner > Cc: Simon Wunderlich > Cc: Antonio Quartulli > Cc: "David S. Miller" > Cc: Stephen Hemminger > Cc: Alexey Kuznetsov > Cc: James Morris > Cc: Hideaki YOSHIFUJI > Cc: Patrick McHardy > Cc: Steffen Klassert > Cc: Herbert Xu > Cc: dri-devel@lists.freedesktop.org > Cc: e1000-devel@lists.sourceforge.net > Cc: netdev@vger.kernel.org > Cc: devel@driverdev.osuosl.org > Cc: linux-fsdevel@vger.kernel.org > Cc: b.a.t.m.a.n@lists.open-mesh.org > Cc: bridge@lists.linux-foundation.org > --- > Patch based on "Add linux-next specific files for 20140606" > > drivers/gpu/drm/drm_hashtab.c | 2 +- > drivers/net/ethernet/intel/i40e/i40e_ethtool.c | 2 +- > drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c | 2 +- > drivers/staging/lustre/lustre/libcfs/hash.c | 4 ++-- > fs/namespace.c | 2 +- > fs/notify/inode_mark.c | 2 +- > fs/notify/vfsmount_mark.c | 2 +- > include/linux/list.h | 12 ++++++------ > include/linux/rculist.h | 6 +++--- > net/batman-adv/fragmentation.c | 2 +- > net/bridge/br_multicast.c | 2 +- > net/ipv4/fib_trie.c | 2 +- > net/ipv6/addrlabel.c | 2 +- > net/xfrm/xfrm_policy.c | 4 ++-- > 14 files changed, 23 insertions(+), 23 deletions(-) drivers/staging/ portion: Acked-by: Greg Kroah-Hartman