linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Ian Kent <raven@themaw.net>
Cc: linux-fsdevel <linux-fsdevel@vger.kernel.org>,
	autofs mailing list <autofs@vger.kernel.org>,
	Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] autofs4 - fix false positive compile error
Date: Wed, 25 Jun 2014 13:06:48 -0700	[thread overview]
Message-ID: <20140625130648.1e3cd0e578602918dc38bb6a@linux-foundation.org> (raw)
In-Reply-To: <20140625124939.31035.84884.stgit@perseus.fritz.box>

On Wed, 25 Jun 2014 20:49:39 +0800 Ian Kent <raven@themaw.net> wrote:

> On strict build environments we can see:
> 
> fs/autofs4/inode.c: In function 'autofs4_fill_super':
> fs/autofs4/inode.c:312: error: 'pgrp' may be used uninitialized in this
> function
> make[2]: *** [fs/autofs4/inode.o] Error 1
> make[1]: *** [fs/autofs4] Error 2
> make: *** [fs] Error 2
> make: *** Waiting for unfinished jobs....
> 
> This is due to the use of pgrp_set being used to indicate pgrp has
> has been set rather than initializing pgrp itself.
> 

Yes, that code seems to be explicitly designed to trigger a gcc warning ;)

What is a "strict build environment"?  Someone's using -Werror for the
entire kernel?  That must make for a miserable life.



  reply	other threads:[~2014-06-25 20:06 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-25 12:49 [PATCH] autofs4 - fix false positive compile error Ian Kent
2014-06-25 20:06 ` Andrew Morton [this message]
2014-06-26  2:28   ` Ian Kent

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140625130648.1e3cd0e578602918dc38bb6a@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=autofs@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=raven@themaw.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).