From: Christoph Hellwig <hch@infradead.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Joe Perches <joe@perches.com>, Al Viro <viro@zeniv.linux.org.uk>,
Jeff Layton <jlayton@poochiereds.net>,
"J. Bruce Fields" <bfields@fieldses.org>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] fs.h: Remove unnecessary extern prototypes
Date: Tue, 1 Jul 2014 00:58:02 -0700 [thread overview]
Message-ID: <20140701075802.GA9606@infradead.org> (raw)
In-Reply-To: <20140630163909.9859f3c55406746129a69e77@linux-foundation.org>
On Mon, Jun 30, 2014 at 04:39:09PM -0700, Andrew Morton wrote:
> > I can fix it and resubmit if you like.
>
> OK. How about we wait for -rc6 or thereabouts? That should minimise
> the pain profile.
Or just drop it. This is the perfect example for a patch having
absolutely no real benefit and introducing a lot of churn.
People need to learn that randomly fixing style in code they don't
maintain or change in a major way is abosolutely poinless. Help with
reviewing newly added code so that it has good style instead.
next prev parent reply other threads:[~2014-07-01 7:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-29 0:20 [PATCH 0/4] fs.h: Kernel style updates Joe Perches
2014-06-29 0:20 ` [PATCH 1/4] fs.h: Remove unnecessary extern prototypes Joe Perches
2014-06-30 23:19 ` Andrew Morton
2014-06-30 23:31 ` Joe Perches
2014-06-30 23:39 ` Andrew Morton
2014-07-01 7:58 ` Christoph Hellwig [this message]
2014-06-29 0:20 ` [PATCH 2/4] fs.h: Whitespace neatening Joe Perches
2014-06-29 0:20 ` [PATCH 3/4] fs.h: A few more whitespace neatenings Joe Perches
2014-06-29 0:20 ` [PATCH 4/4] fs: asus_atk0110: Fix DEFINE_SIMPLE_ATTRIBUTE semicolon definition and use Joe Perches
2014-06-29 1:16 ` Guenter Roeck
2014-06-30 13:34 ` Luca Tettamanti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140701075802.GA9606@infradead.org \
--to=hch@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=bfields@fieldses.org \
--cc=jlayton@poochiereds.net \
--cc=joe@perches.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).