From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Subject: Re: please do not merge 058504edd026 (was Re: fs: use after free in /proc/pid/mountinfo) Date: Mon, 7 Jul 2014 16:05:42 -0700 Message-ID: <20140707230542.GJ11171@kroah.com> References: <53B3F331.7090204@oracle.com> <53B4CAB8.5070407@oracle.com> <53B6C051.2060704@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Sasha Levin , stable@vger.kernel.org, Al Viro , Jan Kara , Dave Jones , Heiko Carstens , Andrew Morton , Linus Torvalds , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org To: David Rientjes Return-path: Content-Disposition: inline In-Reply-To: Sender: stable-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Fri, Jul 04, 2014 at 03:35:54PM -0700, David Rientjes wrote: > On Fri, 4 Jul 2014, Sasha Levin wrote: > > > > Does this now reproduce on Linus's tree? If so, does reverting commit > > > 058504edd026 ("fs/seq_file: fallback to vmalloc allocation") prevent this > > > issue? > > > > > > This is a use-after-free since the poison value is 0x6b and I'm presuming > > > that your /proc/self/mountinfo may be larger than PAGE_SIZE in your > > > testing environment. > > > > > > > Good call, reverting that patch made both issues go away. > > > > Thanks for checking, Sasha. > > Stable maintainers, please do not merge commit 058504edd026 ("fs/seq_file: > fallback to vmalloc allocation") that is annotated with a cc for > stable@vger.kernel.org in Linus's tree into stable kernels. > > Although we're at 3.16-rc3, I'm hoping that we can get a fix for the > use-after-free in the next couple days before asking for a revert. Sasha > confirms[*] this commit causes the bug. I should also drop "Subject: /proc/stat: convert to single_open_size()" from the -stable tree, right? thanks, greg k-h