linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jan Kara <jack@suse.cz>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Gioh Kim <gioh.kim@lge.com>,
	Alexander Viro <viro@zeniv.linux.org.uk>,
	Andrew Morton <akpm@linux-foundation.org>,
	"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
	Jan Kara <jack@suse.cz>,
	linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
	Theodore Ts'o <tytso@mit.edu>,
	Andreas Dilger <adilger.kernel@dilger.ca>,
	linux-ext4@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH 0/2] new API to allocate buffer-cache for superblock in non-movable area
Date: Tue, 22 Jul 2014 11:38:38 +0200	[thread overview]
Message-ID: <20140722093838.GA22331@quack.suse.cz> (raw)
In-Reply-To: <20140722073005.GT3935@laptop>

On Tue 22-07-14 09:30:05, Peter Zijlstra wrote:
> On Tue, Jul 22, 2014 at 02:18:47PM +0900, Gioh Kim wrote:
> > Hello,
> > 
> > This patch try to solve problem that a long-lasting page cache of
> > ext4 superblock disturbs page migration.
> > 
> > I've been testing CMA feature on my ARM-based platform
> > and found some pages for page caches cannot be migrated.
> > Some of them are page caches of superblock of ext4 filesystem.
> > 
> > Current ext4 reads superblock with sb_bread(). sb_bread() allocates page
> > from movable area. But the problem is that ext4 hold the page until
> > it is unmounted. If root filesystem is ext4 the page cannot be migrated forever.
> > 
> > I introduce a new API for allocating page from non-movable area.
> > It is useful for ext4 and others that want to hold page cache for a long time.
> 
> There's no word on why you can't teach ext4 to still migrate that page.
> For all I know it might be impossible, but at least mention why.
  It doesn't seem to be worth the effort to make that page movable to me
(it's reasonably doable since superblock buffer isn't accessed in *that*
many places but single movable page doesn't seem like a good tradeoff for
the complexity).

But this made me look into the migration code and it isn't completely clear
to me what makes the migration code decide that sb buffer isn't movable? We
seem to be locking the buffers before moving the underlying page but we
don't do any reference or state checks on the buffers... That seems to be
assuming that noone looks at bh->b_data without holding buffer lock. That
is likely true for ordinary data but definitely not true for metadata
buffers (i.e., buffers for pages from block device mappings).

Added linux-mm to CC to enlighten me a bit ;)

								Honza
-- 
Jan Kara <jack@suse.cz>
SUSE Labs, CR

  parent reply	other threads:[~2014-07-22  9:38 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-22  5:18 [PATCH 0/2] new API to allocate buffer-cache for superblock in non-movable area Gioh Kim
2014-07-22  7:30 ` Peter Zijlstra
2014-07-22  8:14   ` Theodore Ts'o
2014-07-27  1:01     ` Theodore Ts'o
2014-07-30  7:56       ` Gioh Kim
2014-07-22  9:38   ` Jan Kara [this message]
2014-07-30  7:44     ` Gioh Kim
2014-07-30  7:57       ` Kyungmin Park
2014-07-30 10:11       ` Jan Kara
2014-07-30 10:19         ` Peter Zijlstra
2014-07-30 23:45           ` Gioh Kim
2014-07-30 23:54         ` Gioh Kim
2014-07-31  0:03           ` Jan Kara
2014-07-31  0:37             ` Gioh Kim
2014-07-31 12:21               ` Jan Kara
2014-08-01  0:07                 ` Gioh Kim
2014-08-01  1:06                   ` Gioh Kim
2014-08-01  9:57                     ` Jan Kara
2014-08-01 13:36                       ` Peter Zijlstra
2014-08-01 15:24                         ` Jan Kara
2014-08-01 16:04                           ` Peter Zijlstra
2014-08-06  6:15                             ` Gioh Kim
2014-08-01  8:34                 ` Joonsoo Kim
2014-08-01  9:15                   ` Jan Kara

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140722093838.GA22331@quack.suse.cz \
    --to=jack@suse.cz \
    --cc=adilger.kernel@dilger.ca \
    --cc=akpm@linux-foundation.org \
    --cc=gioh.kim@lge.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=paulmck@linux.vnet.ibm.com \
    --cc=peterz@infradead.org \
    --cc=tytso@mit.edu \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).