From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Layton Subject: Re: [PATCH 4/9] fs.h: Add argument names to struct file_lock_operations (*funcs) Date: Wed, 23 Jul 2014 13:59:14 -0400 Message-ID: <20140723135914.0f099e95@tlielax.poochiereds.net> References: Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: Andrew Morton , Al Viro , David Teigland , "J. Bruce Fields" , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org To: Joe Perches Return-path: Received: from mail-qa0-f46.google.com ([209.85.216.46]:58045 "EHLO mail-qa0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932289AbaGWR7S (ORCPT ); Wed, 23 Jul 2014 13:59:18 -0400 Received: by mail-qa0-f46.google.com with SMTP id v10so1662572qac.19 for ; Wed, 23 Jul 2014 10:59:17 -0700 (PDT) In-Reply-To: Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Sun, 20 Jul 2014 11:23:38 -0700 Joe Perches wrote: > Function pointer struct members without argument type names > are not very clear. Add them. > > Signed-off-by: Joe Perches > --- > include/linux/fs.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/include/linux/fs.h b/include/linux/fs.h > index 05be298..65685a7 100644 > --- a/include/linux/fs.h > +++ b/include/linux/fs.h > @@ -834,8 +834,8 @@ static inline struct file *get_file(struct file *f) > typedef void *fl_owner_t; > > struct file_lock_operations { > - void (*fl_copy_lock)(struct file_lock *, struct file_lock *); > - void (*fl_release_private)(struct file_lock *); > + void (*fl_copy_lock)(struct file_lock *dst, struct file_lock *fl); > + void (*fl_release_private)(struct file_lock *fl); > }; > > struct lock_manager_operations { Seems trivial, but ok... Acked-by: Jeff Layton