From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Teigland Subject: Re: [PATCH 9/9] fs: dlm: lockd: Convert int result to unsigned char type Date: Wed, 23 Jul 2014 13:33:32 -0500 Message-ID: <20140723183332.GA21992@redhat.com> References: <65b9ba0dba9c79a938267d5bed7ed0a8211e89ed.1405879494.git.joe@perches.com> <20140723141139.2cf90cb0@tlielax.poochiereds.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Joe Perches , Andrew Morton , Al Viro , Christine Caulfield , "J. Bruce Fields" , Trond Myklebust , cluster-devel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Jeff Layton Return-path: Content-Disposition: inline In-Reply-To: <20140723141139.2cf90cb0-9yPaYZwiELC+kQycOl6kW4xkIHaj4LzF@public.gmane.org> Sender: linux-nfs-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-fsdevel.vger.kernel.org On Wed, Jul 23, 2014 at 02:11:39PM -0400, Jeff Layton wrote: > On Sun, 20 Jul 2014 11:23:43 -0700 > Joe Perches wrote: > > > op->info.rv is an s32, but it's only used as a u8. > > > > I don't understand this patch. info.rv is s32 (and I assume that "rv" > stands for "return value"). What I don't get is why you think it's just > used as a u8. It seems to be used more like a bool than anything else, Thank you, Jeff. /* info.rv from userspace is 1 for conflict, 0 for no-conflict, -ENOENT if there are no locks on the file */ rv = op->info.rv; > and I'm not sure that "type" is really a good description for it. Maybe > it should be a "bool" and named "conflict", given the comments in > dlm_posix_get ? type is not a good name. Sorry Joe, I'm not a fan of your patches. Dave -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html