From: Dave Chinner <david@fromorbit.com>
To: JP Abgrall <jpa@google.com>
Cc: linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org,
Geremy Condra <gcondra@google.com>
Subject: Re: [PATCH] ext4: Add support for FIDTRIM, a best-effort ioctl for deep discard trim
Date: Thu, 24 Jul 2014 22:08:01 +1000 [thread overview]
Message-ID: <20140724120801.GA26465@dastard> (raw)
In-Reply-To: <1406159238-7557-1-git-send-email-jpa@google.com>
On Wed, Jul 23, 2014 at 04:47:18PM -0700, JP Abgrall wrote:
> diff --git a/include/uapi/linux/fs.h b/include/uapi/linux/fs.h
> index ca1a11b..a1816ca 100644
> --- a/include/uapi/linux/fs.h
> +++ b/include/uapi/linux/fs.h
> @@ -156,6 +156,7 @@ struct inodes_stat_t {
> #define FIFREEZE _IOWR('X', 119, int) /* Freeze */
> #define FITHAW _IOWR('X', 120, int) /* Thaw */
> #define FITRIM _IOWR('X', 121, struct fstrim_range) /* Trim */
> +#define FIDTRIM _IOWR('X', 122, struct fstrim_range) /* Deep discard trim */
The 'X' ioctl namespace is actually XFS's ioctl namespace. FIDTRIM
should be in the 'f' namespace - FIFREEZE and FITHAW were inherited
from XFS, which is where that came from originally, and it got
propagated to FITRIM and it wasn't caught on review. I only noticed
that now:
#define XFS_IOC_FSSETDM_BY_HANDLE _IOW ('X', 121, struct xfs_fsop_setdm_handlereq)
#define XFS_IOC_ATTRLIST_BY_HANDLE _IOW ('X', 122, struct xfs_fsop_attrlist_handlereq)
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2014-07-24 12:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-23 23:47 [PATCH] ext4: Add support for FIDTRIM, a best-effort ioctl for deep discard trim JP Abgrall
2014-07-24 12:08 ` Dave Chinner [this message]
2014-07-25 1:50 ` JP Abgrall
2014-07-25 3:46 ` Andreas Dilger
-- strict thread matches above, loose matches on Subject: below --
2014-07-29 22:58 JP Abgrall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140724120801.GA26465@dastard \
--to=david@fromorbit.com \
--cc=gcondra@google.com \
--cc=jpa@google.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).