linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Tim Chen <tim.c.chen@linux.intel.com>
Cc: Christoph Hellwig <hch@infradead.org>,
	Al Viro <viro@zeniv.linux.org.uk>,
	suruchi <suruchi.a.kadu@intel.com>, ak <ak@linux.intel.com>,
	Dave Hansen <dave.hansen@intel.com>,
	Matthew Wilcox <willy@linux.intel.com>,
	"hubert.nueckel" <hubert.nueckel@intel.com>,
	beth.marsh-prime@intel.com, "doug.nelson" <doug.nelson@intel.com>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	linux-fsdevel <linux-fsdevel@vger.kernel.org>,
	Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [Regression 3.16-rc kernel] -55% reduction in throughput for OLTP benchmark
Date: Tue, 29 Jul 2014 17:12:48 -0700	[thread overview]
Message-ID: <20140730001248.GA32367@infradead.org> (raw)
In-Reply-To: <1406678232.2970.943.camel@schen9-DESK>

On Tue, Jul 29, 2014 at 04:57:12PM -0700, Tim Chen wrote:
> Christoph, we're glad to report that this patch does fix the problem.
> Wonder if Al or someone can pick it up.  It is a large regression
> that should not be left unfixed for 3.16.

Al has been away for a bit, and I prepared the last VFS pull.  I'll pick
it up for now and either Al or I will send it on before next weekend.

Can I get a tested-by tag from you for the patch?  Can anyone else
please cross check it?  The new total value might be different from
the old size value when we do a short write, but I can't see how
an async write would be a good thing if we had to finish the remainder
using buffered I/O if the old code really allowed that.

  reply	other threads:[~2014-07-30  0:12 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-28 21:51 [Regression 3.16-rc kernel] -55% reduction in throughput for OLTP benchmark Tim Chen
2014-07-29 14:19 ` Christoph Hellwig
2014-07-29 16:35   ` Tim Chen
2014-07-29 16:49     ` Christoph Hellwig
2014-07-29 17:41       ` Tim Chen
2014-07-29 23:57       ` Tim Chen
2014-07-30  0:12         ` Christoph Hellwig [this message]
2014-07-31 16:13           ` Tim Chen
2014-07-31 17:07             ` Linus Torvalds
2014-07-31 17:10               ` Christoph Hellwig
2014-07-31 17:22                 ` Linus Torvalds
2014-08-01  6:45           ` Al Viro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140730001248.GA32367@infradead.org \
    --to=hch@infradead.org \
    --cc=ak@linux.intel.com \
    --cc=beth.marsh-prime@intel.com \
    --cc=dave.hansen@intel.com \
    --cc=doug.nelson@intel.com \
    --cc=hubert.nueckel@intel.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=suruchi.a.kadu@intel.com \
    --cc=tim.c.chen@linux.intel.com \
    --cc=torvalds@linux-foundation.org \
    --cc=viro@zeniv.linux.org.uk \
    --cc=willy@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).