From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Chinner Subject: Re: [RFC PATCH 1/2] fs: Add dirreadahead syscall and VFS hooks Date: Thu, 31 Jul 2014 13:31:56 +1000 Message-ID: <20140731033156.GQ26465@dastard> References: <1406309851-10628-1-git-send-email-adas@redhat.com> <1406309851-10628-2-git-send-email-adas@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Abhi Das , Linux Kernel , Linux-Fsdevel , cluster-devel , Linux API To: Michael Kerrisk Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-api-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-fsdevel.vger.kernel.org On Tue, Jul 29, 2014 at 10:21:50AM +0200, Michael Kerrisk wrote: > [CC+=linux-api] > > On Fri, Jul 25, 2014 at 7:37 PM, Abhi Das wrote: > > Also adds a void *opaque field to struct dir_context that can be > > used by filesystems to temporarily store any context as this > > struct gets passed around in the fs. So the prototype is: int dir_readahead(int fd, off64_t offset, unsigned int count); Why do we need a new syscall for this? $ man 2 readahead .... ssize_t readahead(int fd, off64_t offset, size_t count); .... EINVAL fd does not refer to a file type to which readahead() can be applied. Cheers, Dave. -- Dave Chinner david-FqsqvQoI3Ljby3iVrkZq2A@public.gmane.org