* [patch] timerfd: remove an always true check
@ 2014-08-01 8:28 Dan Carpenter
2014-08-01 8:32 ` Cyrill Gorcunov
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2014-08-01 8:28 UTC (permalink / raw)
To: Thomas Gleixner, Cyrill Gorcunov
Cc: Alexander Viro, linux-fsdevel, kernel-janitors
We would have returned -EINVAL earlier if ticks wasn't set.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/fs/timerfd.c b/fs/timerfd.c
index 80c3502..b46ffa9 100644
--- a/fs/timerfd.c
+++ b/fs/timerfd.c
@@ -333,8 +333,7 @@ static long timerfd_ioctl(struct file *file, unsigned int cmd, unsigned long arg
spin_lock_irq(&ctx->wqh.lock);
if (!timerfd_canceled(ctx)) {
ctx->ticks = ticks;
- if (ticks)
- wake_up_locked(&ctx->wqh);
+ wake_up_locked(&ctx->wqh);
} else
ret = -ECANCELED;
spin_unlock_irq(&ctx->wqh.lock);
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-08-01 8:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-08-01 8:28 [patch] timerfd: remove an always true check Dan Carpenter
2014-08-01 8:32 ` Cyrill Gorcunov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).