From mboxrd@z Thu Jan 1 00:00:00 1970 From: Oleg Nesterov Subject: [RFC PATCH 0/5] introduce proc_inode->pid_entry Date: Fri, 8 Aug 2014 20:57:32 +0200 Message-ID: <20140808185732.GA760@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org To: Alexander Viro , Alexey Dobriyan , Andrew Morton , Cyrill Gorcunov , David Howells , "David S. Miller" , "Eric W. Biederman" , "Kirill A. Shutemov" , Peter Zijlstra , Sasha Levin Return-path: Received: from mx1.redhat.com ([209.132.183.28]:7891 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751034AbaHHS74 (ORCPT ); Fri, 8 Aug 2014 14:59:56 -0400 Content-Disposition: inline Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Hello, Obviously not for inclusion. The patches are horrible, break task_nommu.c, untested, etc. Only to explain what I mean and discuss the intent, at least. On top of recent /proc/pid/*maps* cleanups I sent. To me it looks a bit annoying that task_mmu.c needs 6 seq_operations's and 6 file_operations's to handle /proc/pid/*maps*. And _only_ because ->show() differs. Eric, et al, what do you think? At least something like 1-3 looks like a good cleanup imho. And afaics we can do more cleanups on top. Oleg. fs/proc/array.c | 17 +--- fs/proc/base.c | 37 +++++++-- fs/proc/inode.c | 1 + fs/proc/internal.h | 16 ++-- fs/proc/task_mmu.c | 237 +++++++++++++--------------------------------------- 5 files changed, 98 insertions(+), 210 deletions(-)