From: Jeremy Allison <jra-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org>
To: Jeff Layton <jeff.layton-7I+n7zu2hftEKMMhf/gKZA@public.gmane.org>
Cc: Steve French <smfrench-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
"linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
linux-fsdevel
<linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
samba-technical
<samba-technical-w/Ol4Ecudpl8XjKLYN78aQ@public.gmane.org>
Subject: Re: [PATCH][CIFS] Workaround MacOS server problem with SMB2.1 write response
Date: Thu, 14 Aug 2014 12:35:19 -0700 [thread overview]
Message-ID: <20140814193519.GB325@samba2> (raw)
In-Reply-To: <20140814153015.030657f7-9yPaYZwiELC+kQycOl6kW4xkIHaj4LzF@public.gmane.org>
On Thu, Aug 14, 2014 at 03:30:15PM -0400, Jeff Layton wrote:
>
> Not directly related to this patch, but...
>
> What's the story behind the check above? Allowing the server to overrun
> the rfc1001 length by one byte seems dangerous...
I vaguely remember a NetApp bug :-).
> I don't understand the rationale for the arbitrary 15 byte limit. At
> this point, you've already received the data. If there's extra junk at
> the end, do you really care? I'd just ensure that clc_len fits within
> the rfc1001 len and leave it at that.
+1 on this. No arbitrary limits please. If you're going
to ignore data after the valid packet, ignore everything
up to the rfc1001 length please. Only ignoring 15 bytes
doesn't make sense. Why 15 ? Why not 27 ?
next prev parent reply other threads:[~2014-08-14 19:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-12 14:19 [PATCH][CIFS] Workaround MacOS server problem with SMB2.1 write response Steve French
2014-08-14 19:30 ` Jeff Layton
[not found] ` <20140814153015.030657f7-9yPaYZwiELC+kQycOl6kW4xkIHaj4LzF@public.gmane.org>
2014-08-14 19:35 ` Jeremy Allison [this message]
2014-08-14 20:26 ` Steve French
[not found] ` <CAH2r5muwftfpt2kjvf4fM78X6JZ5H-Kt415+Z2AojTDUkPrArA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-08-14 20:40 ` Jeff Layton
2014-08-14 20:44 ` Jeremy Allison
2014-08-14 21:15 ` Steve French
[not found] ` <CAH2r5mtE5efZKnroxXerfWLEgGdx-6Wry4788HiPKUaa+bhhLg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-08-14 21:21 ` Jeremy Allison
2014-08-14 20:37 ` Steve French
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140814193519.GB325@samba2 \
--to=jra-eunubhrolfbytjvyw6ydsg@public.gmane.org \
--cc=jeff.layton-7I+n7zu2hftEKMMhf/gKZA@public.gmane.org \
--cc=linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=samba-technical-w/Ol4Ecudpl8XjKLYN78aQ@public.gmane.org \
--cc=smfrench-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).