From: Jeremy Allison <jra@samba.org>
To: Jeff Layton <jeff.layton@primarydata.com>
Cc: Steve French <smfrench@gmail.com>, Jeremy Allison <jra@samba.org>,
"linux-cifs@vger.kernel.org" <linux-cifs@vger.kernel.org>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
samba-technical <samba-technical@lists.samba.org>
Subject: Re: [PATCH][CIFS] Workaround MacOS server problem with SMB2.1 write response
Date: Thu, 14 Aug 2014 13:44:24 -0700 [thread overview]
Message-ID: <20140814204424.GE325@samba2> (raw)
In-Reply-To: <20140814164014.36023859@tlielax.poochiereds.net>
On Thu, Aug 14, 2014 at 04:40:14PM -0400, Jeff Layton wrote:
>
> Failing here won't change the buffer allocation. That buffer has
> already been allocated, and the receive is complete at this point. So
> any "damage" has already been done.
Yep. You've got to have read the data to know it's too much !
> So, I just don't get why you'd bother with an arbitrary limit at all.
> The error checking is _simpler_ if you don't bother with this limit. Or
> am I missing something here?
Nope. The server has to deal with the same problem
as well. We just accept what the client sends inside
the NetBIOS length limit, and ignore anything after
the "useful" data within the packet.
Doesn't matter *what* is in the extra bits, code
data, whatever. We don't look at it.
Steve, what is the problem with just ignoring the
extra data ? If it offends you - log a warning
message is the rfc1001 length is too long and
ignore it.
next prev parent reply other threads:[~2014-08-14 20:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-12 14:19 [PATCH][CIFS] Workaround MacOS server problem with SMB2.1 write response Steve French
2014-08-14 19:30 ` Jeff Layton
[not found] ` <20140814153015.030657f7-9yPaYZwiELC+kQycOl6kW4xkIHaj4LzF@public.gmane.org>
2014-08-14 19:35 ` Jeremy Allison
2014-08-14 20:26 ` Steve French
[not found] ` <CAH2r5muwftfpt2kjvf4fM78X6JZ5H-Kt415+Z2AojTDUkPrArA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-08-14 20:40 ` Jeff Layton
2014-08-14 20:44 ` Jeremy Allison [this message]
2014-08-14 21:15 ` Steve French
[not found] ` <CAH2r5mtE5efZKnroxXerfWLEgGdx-6Wry4788HiPKUaa+bhhLg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-08-14 21:21 ` Jeremy Allison
2014-08-14 20:37 ` Steve French
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140814204424.GE325@samba2 \
--to=jra@samba.org \
--cc=jeff.layton@primarydata.com \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=samba-technical@lists.samba.org \
--cc=smfrench@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).