From: Christoph Hellwig <hch@infradead.org>
To: Ming Lei <ming.lei@canonical.com>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Dave Kleikamp <dave.kleikamp@oracle.com>,
Zach Brown <zab@zabbo.net>, Benjamin LaHaise <bcrl@kvack.org>,
Christoph Hellwig <hch@infradead.org>,
Kent Overstreet <kmo@daterainc.com>,
linux-aio@kvack.org, linux-fsdevel@vger.kernel.org,
Dave Chinner <david@fromorbit.com>
Subject: Re: [PATCH v1 5/9] block: loop: convert to blk-mq
Date: Fri, 15 Aug 2014 09:31:11 -0700 [thread overview]
Message-ID: <20140815163111.GA16652@infradead.org> (raw)
In-Reply-To: <1408031441-31156-6-git-send-email-ming.lei@canonical.com>
> +
> +static int loop_init_hctx(struct blk_mq_hw_ctx *hctx, void *data,
> + unsigned int index)
> +{
> + struct loop_device *lo = data;
> +
> + hctx->driver_data = lo;
I don't think there is much of a point to store this in the hctx
instead of relying on the queue.
> +static void loop_softirq_done_fn(struct request *rq)
> +{
> + blk_mq_end_io(rq, rq->errors);
> +}
no need for a noop softirq done function.
> +static void loop_queue_work(struct work_struct *work)
Offloading work straight to a workqueue dosn't make much sense
in the blk-mq model as we'll usually be called from one. If you
need to avoid the cases where we are called directly a flag for
the blk-mq code to always schedule a workqueue sounds like a much
better plan.
--
To unsubscribe, send a message with 'unsubscribe linux-aio' in
the body to majordomo@kvack.org. For more info on Linux AIO,
see: http://www.kvack.org/aio/
Don't email: <a href=mailto:"aart@kvack.org">aart@kvack.org</a>
next prev parent reply other threads:[~2014-08-15 16:31 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-14 15:50 [PATCH v1 0/9] block & aio: kernel aio and loop mq conversion Ming Lei
2014-08-14 15:50 ` [PATCH v1 1/9] aio: add aio_kernel_() interface Ming Lei
2014-08-14 18:07 ` Zach Brown
2014-08-15 13:20 ` Ming Lei
2014-08-14 15:50 ` [PATCH v1 2/9] fd/direct-io: introduce should_dirty for kernel aio Ming Lei
2014-08-14 15:50 ` [PATCH v1 3/9] blk-mq: export blk_mq_freeze_queue and blk_mq_unfreeze_queue Ming Lei
2014-08-14 15:50 ` [PATCH v1 4/9] blk-mq: introduce init_flush_rq_fn callback in 'blk_mq_ops' Ming Lei
2014-08-15 16:19 ` Jens Axboe
2014-08-16 7:49 ` Ming Lei
2014-08-17 18:39 ` Jens Axboe
2014-08-14 15:50 ` [PATCH v1 5/9] block: loop: convert to blk-mq Ming Lei
2014-08-15 16:31 ` Christoph Hellwig [this message]
2014-08-15 16:36 ` Jens Axboe
2014-08-15 16:46 ` Jens Axboe
2014-08-16 8:06 ` Ming Lei
2014-08-17 17:48 ` Jens Axboe
2014-08-18 1:22 ` Ming Lei
2014-08-18 11:53 ` Ming Lei
2014-08-19 20:50 ` Jens Axboe
[not found] ` <CACVXFVP_q2MfZtjPAgXrjMJS2K6H2fTFtAe3ZJXBW83uEovqkQ@mail.gmail.com>
2014-08-20 16:09 ` Jens Axboe
[not found] ` <CACVXFVPxXrYi+m0bC7tEcfvDzhQ=Xnapkd+yGRXbKCktgi3Ofw@mail.gmail.com>
2014-08-21 2:58 ` Jens Axboe
[not found] ` <CACVXFVNEuEOXphJK5XGbAGRC9tL7iTv=PE_v+Dnw3CReAEkonw@mail.gmail.com>
2014-08-21 3:16 ` Jens Axboe
[not found] ` <CACVXFVOR0mzMWo+iPtU8jUvYgH+non=hQ0XaP0Z1Fu0qiSbJNA@mail.gmail.com>
2014-08-27 16:08 ` Maxim Patlasov
2014-08-27 16:29 ` Benjamin LaHaise
2014-08-27 17:19 ` Maxim Patlasov
2014-08-27 17:56 ` Zach Brown
2014-08-28 2:10 ` Ming Lei
2014-08-28 2:06 ` Ming Lei
2014-08-29 11:14 ` Maxim Patlasov
2014-08-14 15:50 ` [PATCH v1 6/9] block: loop: say goodby to bio Ming Lei
2014-08-14 15:50 ` [PATCH v1 7/9] block: loop: introduce lo_discard() and lo_req_flush() Ming Lei
2014-08-14 15:50 ` [PATCH v1 8/9] block: loop: don't handle REQ_FUA explicitly Ming Lei
2014-08-14 15:50 ` [PATCH v1 9/9] block: loop: support to submit I/O via kernel aio based Ming Lei
2014-08-14 16:53 ` [PATCH v1 0/9] block & aio: kernel aio and loop mq conversion Jens Axboe
2014-08-15 12:59 ` Ming Lei
2014-08-15 13:11 ` Christoph Hellwig
2014-08-15 14:32 ` Ming Lei
-- strict thread matches above, loose matches on Subject: below --
2014-08-29 10:41 [PATCH v1 5/9] block: loop: convert to blk-mq Maxim Patlasov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140815163111.GA16652@infradead.org \
--to=hch@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=bcrl@kvack.org \
--cc=dave.kleikamp@oracle.com \
--cc=david@fromorbit.com \
--cc=kmo@daterainc.com \
--cc=linux-aio@kvack.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.lei@canonical.com \
--cc=zab@zabbo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).