* [PATCH] fs: aio: Replace rcu_assign_pointer() with RCU_INIT_POINTER()
@ 2014-08-22 13:57 Andreea-Cristina Bernat
0 siblings, 0 replies; only message in thread
From: Andreea-Cristina Bernat @ 2014-08-22 13:57 UTC (permalink / raw)
To: viro, bcrl, linux-fsdevel, linux-aio, linux-kernel; +Cc: paulmck
The use of "rcu_assign_pointer()" is NULLing out the pointer.
According to RCU_INIT_POINTER()'s block comment:
"1. This use of RCU_INIT_POINTER() is NULLing out the pointer"
it is better to use it instead of rcu_assign_pointer() because it has a
smaller overhead.
The following Coccinelle semantic patch was used:
@@
@@
- rcu_assign_pointer
+ RCU_INIT_POINTER
(..., NULL)
Signed-off-by: Andreea-Cristina Bernat <bernat.ada@gmail.com>
---
fs/aio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/aio.c b/fs/aio.c
index 4f078c0..81f7f3f 100644
--- a/fs/aio.c
+++ b/fs/aio.c
@@ -802,7 +802,7 @@ void exit_aio(struct mm_struct *mm)
do {
if (!table || i >= table->nr) {
rcu_read_unlock();
- rcu_assign_pointer(mm->ioctx_table, NULL);
+ RCU_INIT_POINTER(mm->ioctx_table, NULL);
if (table)
kfree(table);
return;
--
1.9.1
--
To unsubscribe, send a message with 'unsubscribe linux-aio' in
the body to majordomo@kvack.org. For more info on Linux AIO,
see: http://www.kvack.org/aio/
Don't email: <a href=mailto:"aart@kvack.org">aart@kvack.org</a>
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2014-08-22 13:57 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-08-22 13:57 [PATCH] fs: aio: Replace rcu_assign_pointer() with RCU_INIT_POINTER() Andreea-Cristina Bernat
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).