From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andreea-Cristina Bernat Subject: [PATCH] fs: aio: Replace rcu_assign_pointer() with RCU_INIT_POINTER() Date: Fri, 22 Aug 2014 16:57:19 +0300 Message-ID: <20140822135719.GA31395@ada> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: paulmck@linux.vnet.ibm.com To: viro@zeniv.linux.org.uk, bcrl@kvack.org, linux-fsdevel@vger.kernel.org, linux-aio@kvack.org, linux-kernel@vger.kernel.org Return-path: Content-Disposition: inline Sender: owner-linux-aio@kvack.org List-Id: linux-fsdevel.vger.kernel.org The use of "rcu_assign_pointer()" is NULLing out the pointer. According to RCU_INIT_POINTER()'s block comment: "1. This use of RCU_INIT_POINTER() is NULLing out the pointer" it is better to use it instead of rcu_assign_pointer() because it has a smaller overhead. The following Coccinelle semantic patch was used: @@ @@ - rcu_assign_pointer + RCU_INIT_POINTER (..., NULL) Signed-off-by: Andreea-Cristina Bernat --- fs/aio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/aio.c b/fs/aio.c index 4f078c0..81f7f3f 100644 --- a/fs/aio.c +++ b/fs/aio.c @@ -802,7 +802,7 @@ void exit_aio(struct mm_struct *mm) do { if (!table || i >= table->nr) { rcu_read_unlock(); - rcu_assign_pointer(mm->ioctx_table, NULL); + RCU_INIT_POINTER(mm->ioctx_table, NULL); if (table) kfree(table); return; -- 1.9.1 -- To unsubscribe, send a message with 'unsubscribe linux-aio' in the body to majordomo@kvack.org. For more info on Linux AIO, see: http://www.kvack.org/aio/ Don't email: aart@kvack.org