From: Robert Elliott <elliott@hp.com>
To: axboe@kernel.dk, webbnh@hp.com, linux-kernel@vger.kernel.org,
relliott@beardog.cce.hp.com, linux-fsdevel@vger.kernel.org,
viro@zeniv.linux.org.uk, elliott@hp.com,
scameron@beardog.cce.hp.com
Subject: [PATCH 1/2] block: make blk_update_request print prefix match ratelimited prefix
Date: Wed, 27 Aug 2014 10:50:31 -0500 [thread overview]
Message-ID: <20140827155031.32075.49783.stgit@beardog.cce.hp.com> (raw)
In-Reply-To: <20140827154628.32075.3821.stgit@beardog.cce.hp.com>
In blk_update_request, change the printk_ratelimited
prefix from end_request to blk_update_request so it
matches the name printed if rate limiting occurs.
Old:
[10234.933106] blk_update_request: 174 callbacks suppressed
[10234.934940] end_request: critical target error, dev sdr, sector 16
[10234.949788] end_request: critical target error, dev sdr, sector 16
New:
[16863.445173] blk_update_request: 398 callbacks suppressed
[16863.447029] blk_update_request: critical target error, dev sdr, sector
1442066176
[16863.449383] blk_update_request: critical target error, dev sdr, sector
802802888
[16863.451680] blk_update_request: critical target error, dev sdr, sector
1609535456
Signed-off-by: Robert Elliott <elliott@hp.com>
Reviewed-by: Webb Scales <webbnh@hp.com>
---
block/blk-core.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/block/blk-core.c b/block/blk-core.c
index c359d72..9c5a5b9 100644
--- a/block/blk-core.c
+++ b/block/blk-core.c
@@ -2450,8 +2450,8 @@ bool blk_update_request(struct request *req, int error, unsigned int nr_bytes)
error_type = "I/O";
break;
}
- printk_ratelimited(KERN_ERR "end_request: %s error, dev %s, sector %llu\n",
- error_type, req->rq_disk ?
+ printk_ratelimited(KERN_ERR "%s: %s error, dev %s, sector %llu\n",
+ __func__, error_type, req->rq_disk ?
req->rq_disk->disk_name : "?",
(unsigned long long)blk_rq_pos(req));
next prev parent reply other threads:[~2014-08-27 15:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-27 15:50 [PATCH 0/2] block: improve I/O error print consistency Robert Elliott
2014-08-27 15:50 ` Robert Elliott [this message]
2014-08-27 15:50 ` [PATCH 2/2] block: include func name in __get_request prints Robert Elliott
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140827155031.32075.49783.stgit@beardog.cce.hp.com \
--to=elliott@hp.com \
--cc=axboe@kernel.dk \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=relliott@beardog.cce.hp.com \
--cc=scameron@beardog.cce.hp.com \
--cc=viro@zeniv.linux.org.uk \
--cc=webbnh@hp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).