linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Al Viro <viro-3bDd1+5oDREiFSDQTTA3OLVCufUGDwFn@public.gmane.org>
To: Trond Myklebust
	<trond.myklebust-7I+n7zu2hftEKMMhf/gKZA@public.gmane.org>
Cc: Devel FS Linux
	<linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Linux NFS Mailing List
	<linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Tao Peng <tao.peng-7I+n7zu2hftEKMMhf/gKZA@public.gmane.org>
Subject: Re: VFS regression: commit aba809cf0944 breaks MNT_SHRINKABLE automounted partitions
Date: Fri, 29 Aug 2014 21:58:17 +0100	[thread overview]
Message-ID: <20140829205817.GB7996@ZenIV.linux.org.uk> (raw)
In-Reply-To: <CAHQdGtT4kbPqQvD_fu7c_5_CqK8FCpA5mJsVdh=KxoE9_vXRzw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>

On Fri, Aug 29, 2014 at 12:27:53PM -0400, Trond Myklebust wrote:
> Hi Al,
> 
> Our internal testing shows that commit aba809cf0944 (namespace.c: get
> rid of mnt_ghosts) appears to break the NFS automounter functionality.
> When unmounting, the user now gets a permanent -EBUSY, presumably due
> to a refcounting issue with the patch.
> 
> The reproducer is as follows:
> 
> On the server, set up an export of the form:
> 
> % showmount -e 192.168.214.128
> Export list for 192.168.214.128:
> /export *
> 
> On the client:
> 
> [fedora19@~]$sudo mount 192.168.214.128:/ /mnt/
> [fedora19@~]$df
> Filesystem               Size  Used Avail Use% Mounted on
> /dev/mapper/fedora-root   38G   15G   24G  38% /
> devtmpfs                 229M     0  229M   0% /dev
> tmpfs                    242M   80K  242M   1% /dev/shm
> tmpfs                    242M  1.5M  241M   1% /run
> tmpfs                    242M     0  242M   0% /sys/fs/cgroup
> tmpfs                    242M  4.0K  242M   1% /tmp
> /dev/sda1                1.5G  248M  1.3G  17% /boot
> 192.168.214.128:/         28G   25G  1.1G  96% /mnt
> [fedora19@~]$ls /mnt/export/
> [fedora19@~]$df
> Filesystem               Size  Used Avail Use% Mounted on
> /dev/mapper/fedora-root   38G   15G   24G  38% /
> devtmpfs                 229M     0  229M   0% /dev
> tmpfs                    242M   80K  242M   1% /dev/shm
> tmpfs                    242M  1.5M  241M   1% /run
> tmpfs                    242M     0  242M   0% /sys/fs/cgroup
> tmpfs                    242M  4.0K  242M   1% /tmp
> /dev/sda1                1.5G  248M  1.3G  17% /boot
> 192.168.214.128:/         28G   25G  1.1G  96% /mnt
> 192.168.214.128:/export   28G   25G  1.1G  96% /mnt/export
> [fedora19@~]$sudo umount /mnt
> umount.nfs4: /mnt: device is busy
> [fedora19@~]$df
> Filesystem               Size  Used Avail Use% Mounted on
> /dev/mapper/fedora-root   38G   15G   24G  38% /
> devtmpfs                 229M     0  229M   0% /dev
> tmpfs                    242M   80K  242M   1% /dev/shm
> tmpfs                    242M  1.5M  241M   1% /run
> tmpfs                    242M     0  242M   0% /sys/fs/cgroup
> tmpfs                    242M  4.0K  242M   1% /tmp
> /dev/sda1                1.5G  248M  1.3G  17% /boot
> 192.168.214.128:/         28G   25G  1.1G  96% /mnt
> 
> Reverting commit aba809cf0944 fixes the problem for us on a 3.14.15
> client kernel.

Can't reproduce on a debian client with 3.12 kernel (which contains the
commit in question); it'll take a bit to get Fedora setup - I have it as KVM
image, but it's sandboxed to hell and back and certainly not allowed to play
with NFS traffic...

In the meanwhile, if you have a reproducer setup...  Could you verify that
fuser -m /mnt does come empty?  Another thing: does mount --make-rprivate /
done before that umount /mnt change behaviour?  IOW, I wonder if it could
be affected by shared-subtree setup; that might be the relevant difference
between the working box and F19 one in this case.  Could you at least post
the contents of /proc/*/mountinfo from all namespaces?  Output of
grep . `md5sum /proc/*/mountinfo|sort|uniq -w32|awk '{print $2}'`
would do...
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2014-08-29 20:58 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-29 16:27 VFS regression: commit aba809cf0944 breaks MNT_SHRINKABLE automounted partitions Trond Myklebust
     [not found] ` <CAHQdGtT4kbPqQvD_fu7c_5_CqK8FCpA5mJsVdh=KxoE9_vXRzw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-08-29 20:58   ` Al Viro [this message]
2014-08-29 21:47     ` Trond Myklebust
     [not found]       ` <CAHQdGtRBqmsfeVVysTnTEELHuwiPwvsyTHtoRAsfSS0aSyCbfQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-08-29 23:01         ` Al Viro
2014-08-30  0:38           ` Peng Tao
     [not found]             ` <CAKVebiWBU3du650yeTMfaFuLr=WLUBc2RukFGyBF6Qgxd6zA8Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-08-30 17:36               ` Al Viro
     [not found]                 ` <20140830173638.GE7996-3bDd1+5oDREiFSDQTTA3OLVCufUGDwFn@public.gmane.org>
2014-08-30 23:27                   ` Al Viro
2014-08-31  0:31                     ` Peng Tao
2014-08-31  4:09                       ` Al Viro
     [not found]                         ` <20140831040910.GH7996-3bDd1+5oDREiFSDQTTA3OLVCufUGDwFn@public.gmane.org>
2014-09-01 23:52                           ` Dave Chinner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140829205817.GB7996@ZenIV.linux.org.uk \
    --to=viro-3bdd1+5odreifsdqtta3olvcufugdwfn@public.gmane.org \
    --cc=linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=tao.peng-7I+n7zu2hftEKMMhf/gKZA@public.gmane.org \
    --cc=trond.myklebust-7I+n7zu2hftEKMMhf/gKZA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).