From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH] locks: flock_make_lock should return a struct file_lock (or PTR_ERR) Date: Thu, 4 Sep 2014 11:09:19 -0700 Message-ID: <20140904180919.GA16897@infradead.org> References: <1409840855-10557-1-git-send-email-jlayton@primarydata.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org To: Jeff Layton Return-path: Content-Disposition: inline In-Reply-To: <1409840855-10557-1-git-send-email-jlayton@primarydata.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Thu, Sep 04, 2014 at 10:27:35AM -0400, Jeff Layton wrote: > Eliminate the need for a return pointer. > > Signed-off-by: Jeff Layton Looks good, Reviewed-by: Christoph Hellwig