From: Al Viro <viro@ZenIV.linux.org.uk>
To: Andrey Vagin <avagin@openvz.org>
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
John McCutchan <john@johnmccutchan.com>,
Robert Love <rlove@rlove.org>, Eric Paris <eparis@parisplace.org>,
Cyrill Gorcunov <gorcunov@openvz.org>,
Pavel Emelyanov <xemul@parallels.com>
Subject: Re: [PATCH] fs: don't remove inotify watchers from alive inode-s
Date: Tue, 9 Sep 2014 02:27:12 +0100 [thread overview]
Message-ID: <20140909012712.GV7996@ZenIV.linux.org.uk> (raw)
In-Reply-To: <1410177716-3965-1-git-send-email-avagin@openvz.org>
On Mon, Sep 08, 2014 at 04:01:56PM +0400, Andrey Vagin wrote:
> Currently watchers are removed in dentry_iput(), if n_link is zero.
> But other detries can be linked with this inode. For example if we
> create two hard links, open the first one and set a watcher on the
> second one. Then if we remove both links, the watcher will be removed.
> But we will have the alive file descriptor, which allows us to generate
> more events.
>
> With this patch, watchers will be removed, only if nlink is zero and
> i_dentry list is empty.
It changes user-visible ABI. Worse yet, this "ABI" has no specification,
so any (misguided) software using that FPOS has nothing to go by other than
"whatever existing kernels do". As the result, inotify behaviour is cast
in concrete.
IOW, NAK.
next prev parent reply other threads:[~2014-09-09 1:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-08 12:01 [PATCH] fs: don't remove inotify watchers from alive inode-s Andrey Vagin
2014-09-08 12:19 ` Cyrill Gorcunov
2014-09-08 14:45 ` Jan Kara
2014-09-09 1:27 ` Al Viro [this message]
2014-09-09 8:54 ` Jan Kara
2014-09-10 9:43 ` Andrew Vagin
2014-09-13 16:15 ` Heinrich Schuchardt
2014-09-16 21:12 ` Jan Kara
2014-09-17 21:01 ` Andrew Vagin
2014-09-18 10:00 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140909012712.GV7996@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=avagin@openvz.org \
--cc=eparis@parisplace.org \
--cc=gorcunov@openvz.org \
--cc=john@johnmccutchan.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rlove@rlove.org \
--cc=xemul@parallels.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).