From: Jeff Layton <jlayton@poochiereds.net>
To: Thomas Jarosch <thomas.jarosch@intra2net.com>
Cc: hch@infradead.org, linux-fsdevel@vger.kernel.org,
Dmitry Torokhov <dtor@vmware.com>
Subject: Re: vfs: getname() / putname() used by VMware drivers
Date: Fri, 12 Sep 2014 22:12:08 -0400 [thread overview]
Message-ID: <20140912221208.02dbf5ea@synchrony.poochiereds.net> (raw)
In-Reply-To: <23918811.SYffIVGlUb@storm>
On Fri, 12 Sep 2014 15:57:39 +0200
Thomas Jarosch <thomas.jarosch@intra2net.com> wrote:
> Hi Jeff,
>
> I just compiled the VMware kernel modules 9.4.6-1770165
> on kernel 3.14.18 (upgrading from 3.4.101).
>
> The functions getname() and putname() are both used
> by the "vmblock" and "vmsync" module.
>
> Any chance to revert 8e377d15078a501c4da98471f56396343c407d92
> ---------------------------------------
> vfs: unexport getname and putname symbols
>
> I see no callers in module code.
> ---------------------------------------
>
> since there are callers to those functions?
>
> Otherwise the VMware code needs to be changed downstream.
> For now I've reverted the commit in question locally.
>
> Cheers,
> Thomas
>
(I've left Red Hat so the redhat.com address no longer works)
As Christoph says...no, there's no way that we'll revert that.
Those functions have hooks into the audit layer and 3rd party modules
almost universally got their usage wrong.
--
Jeff Layton <jlayton@poochiereds.net>
next prev parent reply other threads:[~2014-09-13 2:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-12 13:57 vfs: getname() / putname() used by VMware drivers Thomas Jarosch
2014-09-12 22:11 ` Christoph Hellwig
2014-09-13 2:12 ` Jeff Layton [this message]
2014-09-15 7:41 ` Thomas Jarosch
2014-09-15 15:28 ` Dmitry Torokhov
2014-09-18 13:48 ` Thomas Jarosch
2014-09-18 17:00 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140912221208.02dbf5ea@synchrony.poochiereds.net \
--to=jlayton@poochiereds.net \
--cc=dtor@vmware.com \
--cc=hch@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=thomas.jarosch@intra2net.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).