From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH 1/7] Prepare for adding a new readv/writev with user flags. Date: Mon, 15 Sep 2014 14:15:23 -0700 Message-ID: <20140915211523.GA5481@infradead.org> References: <20140915202828.GV7996@ZenIV.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Milosz Tanski , linux-kernel@vger.kernel.org, Christoph Hellwig , linux-fsdevel@vger.kernel.org, linux-aio@kvack.org, Mel Gorman , Volker Lendecke , Tejun Heo , Jeff Moyer To: Al Viro Return-path: Content-Disposition: inline In-Reply-To: <20140915202828.GV7996@ZenIV.linux.org.uk> Sender: owner-linux-aio@kvack.org List-Id: linux-fsdevel.vger.kernel.org On Mon, Sep 15, 2014 at 09:28:28PM +0100, Al Viro wrote: > On Mon, Sep 15, 2014 at 04:20:17PM -0400, Milosz Tanski wrote: > > Plumbing the flags argument through the vfs code so they can be passed down to > > __generic_file_(read/write)_iter function that do the acctual work. > > NAK. Put these flags into iocb, it'll be less noisy that way. Fine with me. My initial prototype had it in the iov_iter type field which is another possibility. But if we get rid of the explicit flags field and make it more invisible I'd really like to add a features field struct file_operations where instances can advertize that they support it (and other things like actual AIO support in the future) so that we won't have a situation like with AIO where we can submit I/O but it might actually still block anyway because lots of operations don't support it. -- To unsubscribe, send a message with 'unsubscribe linux-aio' in the body to majordomo@kvack.org. For more info on Linux AIO, see: http://www.kvack.org/aio/ Don't email: aart@kvack.org