From: Dave Jones <davej@redhat.com>
To: Michal Hocko <mhocko@suse.cz>
Cc: Andrew Morton <akpm@linux-foundation.org>,
mm-commits@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, linux-fsdevel@vger.kernel.org,
linux-next@vger.kernel.org, sfr@canb.auug.org.au,
Sasha Levin <sasha.levin@oracle.com>
Subject: Re: [PATCH] mm, debug: mm-introduce-vm_bug_on_mm-fix-fix.patch
Date: Tue, 23 Sep 2014 16:12:04 -0400 [thread overview]
Message-ID: <20140923201204.GB4252@redhat.com> (raw)
In-Reply-To: <20140923112848.GA10046@dhcp22.suse.cz>
On Tue, Sep 23, 2014 at 01:28:48PM +0200, Michal Hocko wrote:
> And there is another one hitting during randconfig. The patch makes my
> eyes bleed but I don't know about other way without breaking out the
> thing into separate parts sounds worse because we can mix with other
> messages then.
how about something along the lines of..
bufptr = buffer = kmalloc()
#if defined(CONFIG_NUMA_BALANCING) || defined(CONFIG_COMPACTION)
bufptr += sprintf(bufptr, "tlb_flush_pending %d\n",
mm->tlb_flush_pending);
#endif
#ifdef CONFIG_MMU
bufptr += sprintf(bufptr, "...
#endif
...
printk(KERN_EMERG "%s", buffer);
free(buffer);
Still ugly, but looks less like a trainwreck, and keeps the variables
with the associated text.
It does introduce an allocation though, which may be problematic
in this situation. Depending how big this gets, perhaps make it static
instead?
Dave
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2014-09-23 20:12 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-23 0:02 mmotm 2014-09-22-16-57 uploaded akpm
2014-09-23 0:39 ` Stephen Rothwell
2014-09-23 1:12 ` Andrew Morton
2014-09-23 9:24 ` [PATCH] mm, debug: mm-introduce-vm_bug_on_mm-fix.patch Michal Hocko
2014-09-23 11:28 ` [PATCH] mm, debug: mm-introduce-vm_bug_on_mm-fix-fix.patch Michal Hocko
2014-09-23 16:19 ` Valdis.Kletnieks
2014-09-23 20:52 ` Andrew Morton
2014-09-24 7:09 ` Michal Hocko
2014-09-23 20:12 ` Dave Jones [this message]
2014-09-23 19:02 ` mmotm 2014-09-22-16-57 uploaded Guenter Roeck
2014-09-23 20:01 ` Andrew Morton
2014-09-23 20:13 ` Fabio Estevam
2014-09-23 20:20 ` Naoya Horiguchi
2014-09-23 20:38 ` Guenter Roeck
2014-09-23 21:08 ` Anish Bhatt
2014-09-23 20:31 ` Randy Dunlap
2014-09-23 20:57 ` Guenter Roeck
2014-09-23 21:36 ` Randy Dunlap
2014-09-23 21:53 ` Guenter Roeck
2014-09-24 4:34 ` Guenter Roeck
2014-09-24 6:24 ` David Miller
2014-09-24 7:18 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140923201204.GB4252@redhat.com \
--to=davej@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-next@vger.kernel.org \
--cc=mhocko@suse.cz \
--cc=mm-commits@vger.kernel.org \
--cc=sasha.levin@oracle.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).