From: Al Viro <viro@ZenIV.linux.org.uk>
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
"Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] vfs: fix linkat error for unprivileged AT_EMPTY_PATH
Date: Wed, 24 Sep 2014 20:00:58 +0100 [thread overview]
Message-ID: <20140924190058.GE7996@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20140924152523.GC7441@tucsk.piliscsaba.szeredi.hu>
On Wed, Sep 24, 2014 at 05:25:23PM +0200, Miklos Szeredi wrote:
> From: Miklos Szeredi <mszeredi@suse.cz>
>
> Return proper error value for linkat(..., AT_EMPTY_PATH) without enough
> privileges.
>
> I guess ENOENT was used here, because without AT_EMPTY_PATH that's what
> we'd return for an empty path. But it is wrong for AT_EMPTY_PATH, since we
> might not even be passing an empty path, we are simply complaining about
> lack of privs for which EPERM is the proper error.
Umm... Are you sure that nothing in userland is checking for that
return value? I agree that EPERM would make more sense, but...
next prev parent reply other threads:[~2014-09-24 19:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-24 15:25 [PATCH] vfs: fix linkat error for unprivileged AT_EMPTY_PATH Miklos Szeredi
2014-09-24 19:00 ` Al Viro [this message]
2014-09-25 14:31 ` Miklos Szeredi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140924190058.GE7996@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).