From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mikhail Efremov Subject: Re: [PATCH v2] vfs: Don't exchange "short" filenames unconditionally. Date: Sun, 28 Sep 2014 19:01:58 +0400 Message-ID: <20140928190158.796d4c18@sem-notebook> References: <1411582473-29184-1-git-send-email-sem@altlinux.org> <20140924185521.GC7996@ZenIV.linux.org.uk> <20140924201813.GI7996@ZenIV.linux.org.uk> <20140925044601.GL7996@ZenIV.linux.org.uk> <20140926164442.GA26897@ZenIV.linux.org.uk> <20140927044555.GS7996@ZenIV.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: Al Viro , Mikhail Efremov , Linux Kernel Mailing List , Miklos Szeredi , linux-fsdevel , stable To: Linus Torvalds Return-path: Received: from pegasus3.altlinux.org ([194.107.17.103]:39112 "EHLO pegasus3.altlinux.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753504AbaI1PCf (ORCPT ); Sun, 28 Sep 2014 11:02:35 -0400 In-Reply-To: Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Sat, 27 Sep 2014 10:56:57 -0700 Linus Torvalds wrote: > (And Mikhail - I'm not ragging on you, even if I'm ragging on the > patch. I understand why you did it the way you did, and it makes sense > exactly in the "let's reinstate old hackery" model. I just think we > can and should do better than that, now that the "exchange" vs "move > over" semantics are so explicit). Well, I can't argue with the fact that this patch is ugly, especially after all this discussion. I just hope that the right solution will be implemented soon and this ugly hack will be dropped. > Al (or Mikhail) - willing to do that extra cleanup? Please? I'll definetly take a look at this, but I doubt that I will be able to implement the right solution soon. Actually this is the first time when I look at the kernel code so deeply. I hope that someone with much more knowledge of the kernel code than my own (Al or Miklos may be) will do that. -- WBR, Mikhail Efremov