From: Jan Kara <jack@suse.cz>
To: Thanos Makatos <thanos.makatos@citrix.com>
Cc: 'Jan Kara' <jack@suse.cz>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
Ross Lagerwall <ross.lagerwall@citrix.com>,
Felipe Franciosi <felipe.franciosi@citrix.com>
Subject: Re: invalidate the buffer heads of a block device
Date: Tue, 30 Sep 2014 12:48:45 +0200 [thread overview]
Message-ID: <20140930104845.GA31117@quack.suse.cz> (raw)
In-Reply-To: <2368A3FCF9F7214298E53C823B0A48EC0420B983@AMSPEX01CL02.citrite.net>
On Tue 30-09-14 10:11:32, Thanos Makatos wrote:
> > Yes, "unknown" process can read data back into pagecache while your ioctl
> > is running thus undoing your work. But if the writes are already visible on the
> > *device* at the moment you run the ioctl, then "unknown" process will just
> > fetch new data and everything is fine... If you need to evict page cache
> > *before* new data is visible on the device, then you need to suspend the
> > device first so that it doesn't serve any IO, then evict page cache, then make
> > new data visible on the device, and finally resume the device.
> > Suspend/resume of the device can be handled by device mapper (it does
> > these tricks when you are changing topology of the device on the fly).
>
> The writes will be visible to the device *before* the ioctl runs so I
> have one thing less to worry about!
>
> Regarding extending the ioctl to invalidate the page cache, do you have
> any suggestions where I could start looking?
You just need to call invalidate_inode_pages2(). That is going to do all
you need.
> Would such a new ioctl have any chance to be accepted upstream?
I believe a possibility for a file to be fully flushed from page cache is
useful at times and if you present well your usecase there are reasonable
chances it will get accepted upstream.
Honza
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR
next prev parent reply other threads:[~2014-09-30 10:48 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-29 16:24 invalidate the buffer heads of a block device Thanos Makatos
2014-09-29 18:11 ` Jan Kara
2014-09-30 8:58 ` Thanos Makatos
2014-09-30 9:19 ` Jan Kara
2014-09-30 9:39 ` Thanos Makatos
2014-09-30 9:55 ` Jan Kara
2014-09-30 10:11 ` Thanos Makatos
2014-09-30 10:48 ` Jan Kara [this message]
2014-09-30 20:53 ` Zach Brown
2014-09-30 21:13 ` Trond Myklebust
2014-10-01 9:05 ` Jan Kara
2014-10-01 11:50 ` Trond Myklebust
2014-10-01 14:07 ` Jan Kara
2014-10-01 14:47 ` Trond Myklebust
2014-10-01 15:15 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140930104845.GA31117@quack.suse.cz \
--to=jack@suse.cz \
--cc=felipe.franciosi@citrix.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=ross.lagerwall@citrix.com \
--cc=thanos.makatos@citrix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).