From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH 1/3] xfs: add RWF_NONBLOCK support Date: Thu, 2 Oct 2014 13:29:52 +0200 Message-ID: <20141002112952.GA32112@lst.de> References: <1412197494-7655-1-git-send-email-hch@lst.de> <1412197494-7655-2-git-send-email-hch@lst.de> <20141001222327.GT4758@dastard> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Christoph Hellwig , Milosz Tanski , linux-fsdevel@vger.kernel.org, xfs@oss.sgi.com To: Dave Chinner Return-path: Received: from verein.lst.de ([213.95.11.211]:44662 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750987AbaJBL3y (ORCPT ); Thu, 2 Oct 2014 07:29:54 -0400 Content-Disposition: inline In-Reply-To: <20141001222327.GT4758@dastard> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Thu, Oct 02, 2014 at 08:23:27AM +1000, Dave Chinner wrote: > Shouldn't that be: > > if (type & XFS_IOLOCK_EXCL) { > mutex_unlock(&VFS_I(ip)->i_mutex); Yes, I will resend the fixed version.