From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Milosz Tanski <milosz@adfin.com>,
linux-fsdevel@vger.kernel.org, xfs@oss.sgi.com
Subject: Re: preadv2/pwritev2 updates
Date: Fri, 3 Oct 2014 07:05:25 +1000 [thread overview]
Message-ID: <20141002210525.GB12693@dastard> (raw)
In-Reply-To: <20141002113123.GB32112@lst.de>
On Thu, Oct 02, 2014 at 01:31:23PM +0200, Christoph Hellwig wrote:
> On Thu, Oct 02, 2014 at 08:26:37AM +1000, Dave Chinner wrote:
> > On Wed, Oct 01, 2014 at 11:04:51PM +0200, Christoph Hellwig wrote:
> > > Hi Miklos,
> > >
> > > attached are the patches that go on top of your
> > > "[RFC v3 0/4] vfs: Non-blockling buffered fs read (page cache only)"
> > > series. The first one adds RWF_NONBLOCK to XFS, the other two
> > > add a new RWF_DSYNC flag that adds a per-operation O_DSYNC flag.
> >
> > Christoph, any plans to add these new syscalls to xfs_io and
> > data integrity tests for the new RWF_DSYNC flag?
>
> I've got some hacked up xfs_io support, but Milosz was planning a
> slight revision of the syscall interface that I'm still waiting for.
>
> How would you want to automatically test for data integrity? That requires
> a powerfail or crash unfortunately and we don't have good infrastructure
> for that yet. I've tested it by adding a printk that RWF_DSYNC triggers
> the same code path as O_DSYNC.
We have the infrastructure in xfstests to do this in a generic way:
use dm-flakey. The fsync tests (generic/311, generic/32[23]) that
Josef wrote that use dm-flakey to prevent writes after the IOs have
completed and check that the data is there after remount.
Similarly, for xfs specific tests we have older tests that use the
shutdown ioctl (e.g. xfs/137-139) by using the godown function to
shut the filesystem down and prevent unmount from writing metadata.
On remount the data should be present.
So there's a couple of different ways you can do this...
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2014-10-02 21:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-01 21:04 preadv2/pwritev2 updates Christoph Hellwig
2014-10-01 21:04 ` [PATCH 1/3] xfs: add RWF_NONBLOCK support Christoph Hellwig
2014-10-01 22:23 ` Dave Chinner
2014-10-02 11:29 ` Christoph Hellwig
2014-10-02 17:33 ` [PATCH 1/3 v2] " Christoph Hellwig
2014-10-01 21:04 ` [PATCH 2/3] fs: pass iocb to generic_write_sync Christoph Hellwig
2014-10-01 21:04 ` [PATCH 3/3] fs: add a flag for per-operation O_DSYNC semantics Christoph Hellwig
2014-10-01 22:26 ` preadv2/pwritev2 updates Dave Chinner
2014-10-02 11:31 ` Christoph Hellwig
2014-10-02 21:05 ` Dave Chinner [this message]
2014-10-08 2:58 ` Milosz Tanski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141002210525.GB12693@dastard \
--to=david@fromorbit.com \
--cc=hch@lst.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=milosz@adfin.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).