From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Chinner Subject: Re: [PATCH 14/16] xfs: rename XFS_IOC_FSGEOM to XFS_IOC_FSGEOM_V2 Date: Tue, 7 Oct 2014 07:33:00 +1100 Message-ID: <20141006203300.GC2301@dastard> References: <20141003214758.GY1865@sgi.com> <20141003220435.GN1865@sgi.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-fsdevel@vger.kernel.org, olaf@sgi.com, xfs@oss.sgi.com To: Ben Myers Return-path: Received: from ipmail06.adl2.internode.on.net ([150.101.137.129]:41023 "EHLO ipmail06.adl2.internode.on.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750991AbaJFUdC (ORCPT ); Mon, 6 Oct 2014 16:33:02 -0400 Content-Disposition: inline In-Reply-To: <20141003220435.GN1865@sgi.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Fri, Oct 03, 2014 at 05:04:35PM -0500, Ben Myers wrote: > From: Ben Myers > > We'll be creating a new versioned XFS_IOC_FSGEOMETRY ioctl and structure > so rename the current revision to _V2. Urk, no. This will result in older applications picking up the new ioctl when they are rebuilt without having explicit support for the new ioctl. Just create a new ioctl with a new name and modify applications to use it. If the kernel does not support the new ioctl, then fall back to the old one in userspace. -Dave. -- Dave Chinner david@fromorbit.com