From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Chinner Subject: Re: [PATCH 15/16] xfs: xfs_fs_geometry returns a number of bytes to copy Date: Tue, 7 Oct 2014 07:41:14 +1100 Message-ID: <20141006204114.GD2301@dastard> References: <20141003214758.GY1865@sgi.com> <20141003220508.GO1865@sgi.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-fsdevel@vger.kernel.org, olaf@sgi.com, xfs@oss.sgi.com To: Ben Myers Return-path: Received: from ipmail06.adl2.internode.on.net ([150.101.137.129]:14364 "EHLO ipmail06.adl2.internode.on.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751213AbaJFUlQ (ORCPT ); Mon, 6 Oct 2014 16:41:16 -0400 Content-Disposition: inline In-Reply-To: <20141003220508.GO1865@sgi.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Fri, Oct 03, 2014 at 05:05:09PM -0500, Ben Myers wrote: > From: Ben Myers > > The versioned xfs_fsop_geom_t will be of variable size. Make > xfs_fs_geometry return the number of bytes to copy out to userspace for > a given version of the structure. xfs_fs_geometry() should be a void right now - it doesn't return any error value at all. Further, the size of the structure that is filled in is determined by the version of the ioctl being called, not the xfs_fs_geometry() function. Hence the caller already knows the size of the structure being used, and hence does not need xfs_fs_geometry() to tell it that information. So I don't think this change is necessary. Cheers, Dave. -- Dave Chinner david@fromorbit.com